Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH v2] phonesim: Extend STK conformance menu with Setup Call items
Date: Thu, 06 Sep 2012 10:25:39 -0500	[thread overview]
Message-ID: <5048C073.3080907@gmail.com> (raw)
In-Reply-To: <1346942582-4873-1-git-send-email-philippe.nunes@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 821 bytes --]

Hi Philippe,

On 09/06/2012 09:43 AM, Philippe Nunes wrote:
> ---
>   src/conformancesimapplication.cpp |  247 +++++++++++++++++++++++++++++++++++++
>   src/simapplication.h              |    2 +
>   2 files changed, 249 insertions(+)

Patch has been applied, but I still had to amend a spot you missed:

> +        case SetupCall_Two_AID:
> +        {
> +            cmd.setType( QSimCommand::SetupCall );
> +            cmd.setDestinationDevice( QSimCommand::Network );
> +            cmd.setText( "CONFIRMATION" );
> +            cmd.setOtherText( "CALL" );
> +            cmd.setNumber( "+012340123456p1p2" );
> +            cmd.setDisposition( QSimCommand::Disconnect );
> +            command( cmd, this, SLOT(sendSetupCallMenu()) );
> +         }
> +         break;

^^^

Regards,
-Denis

      reply	other threads:[~2012-09-06 15:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-06 14:43 [PATCH v2] phonesim: Extend STK conformance menu with Setup Call items Philippe Nunes
2012-09-06 15:25 ` Denis Kenzior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5048C073.3080907@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox