From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] alcatel: create sim atom with vendor alcatel
Date: Thu, 15 Nov 2012 12:32:00 -0600 [thread overview]
Message-ID: <50A53520.8020907@gmail.com> (raw)
In-Reply-To: <1352891320-29766-1-git-send-email-cedric.jehasse@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 885 bytes --]
Hi Cedric,
On 11/14/2012 05:08 AM, Cedric Jehasse wrote:
> From: Cedric Jehasse<cedric.jehasse@softathome.com>
>
> ---
> plugins/alcatel.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Patch has been applied, but I had to amend it.
>
> diff --git a/plugins/alcatel.c b/plugins/alcatel.c
> index 8005170..e3e7086 100644
> --- a/plugins/alcatel.c
> +++ b/plugins/alcatel.c
> @@ -230,7 +230,7 @@ static void alcatel_pre_sim(struct ofono_modem *modem)
> DBG("%p", modem);
>
> ofono_devinfo_create(modem, 0, "atmodem", data->aux);
> - sim = ofono_sim_create(modem, 0, "atmodem", data->aux);
> + sim = ofono_sim_create(modem, OFONO_VENDOR_ALCATEL, "atmodem", data->aux);
Please make sure to stay within 80 characters per line.
>
> if (sim&& data->have_sim == TRUE)
> ofono_sim_inserted_notify(sim, TRUE);
Regards,
-Denis
prev parent reply other threads:[~2012-11-15 18:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-14 11:08 [PATCH] alcatel: create sim atom with vendor alcatel Cedric Jehasse
2012-11-15 18:32 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A53520.8020907@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox