Re: [PATCH 1/1] telit: stay 'online' until POST_SIM state reached

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2306 bytes --]

Hi Christopher,

On 12/10/2012 11:11 AM, Christopher Vogl wrote:
> Hi Denis,
>
> On 10/12/12 17:49, Denis Kenzior wrote:
>> Hi Christopher,
>>
>>> I also tried the HE910 and had the same problem. In case a PIN is
>>> required, the following solves the problem:
>>>
>>> In /drivers/atmodem/sim.c, at_qss_notify()
>>> case 2: /* PIN unlocked */
>>> has to be changed to
>>> case 3: /* SIM INSERTED and READY */
>>>
>>>
>>> After the PIN was entered, we wait until the modem states that the SIM
>>> is ready, i.e. #QSS: 3.
>>>
>>>
>>> I haven't found a proper way to do this in case there is no PIN
>>> required.
>>> We should only get to "post sim state" if we received #QSS: 3
>>>
>>
>> The current work around is to signal sim_inserted only when you know
>> it is ready.
> But then we have the problem that we cannot enter a PIN code if there is
> one.
> We will be waiting for '#QSS: 3' (SIM ready), but this will only follow
> after '#QSS: 2' (SIM unlocked).

I'm still lost why we need to wait until QSS:3.  However, the modem 
driver can always check CPIN itself prior to calling inserted_notify.

>
>> This is less than ideal since oFono can read non-PIN protected files
>> from the SIM as soon as the SIM is inserted (e.g. ICCID, EFpl, etc).
>> However, the modem behavior is quite strange in this area.
>>
>>>
>>> Is it really unusual for a modem to deactivate the SIM in flight mode? I
>>> had a look at some mobile phones and they seem to deactivate the SIM in
>>> flight mode.
>>>
>>
>> I've not seen one that turns off the SIM. After all, it would be
>> pretty inconvenient not to read SMS messages or access contacts, or
>> mess with MSISDN, or any other setting that is on the SIM.
>
> My Samsung Galaxy Note seems to deactivate the SIM in flight mode - at
> least the SIM contacts disappear, I have not tried the other things yet
> With the HTC One X you have to enter the PIN when you exit the flight mode.
>

That seems really stupid/inconvenient.  Particularly the PIN entry part.

If the modem does not support a mode where the RX/TX circuits are off 
but the SIM card is powered, then the likely approach is to remove the 
set_online method completely and make sure everything still behaves as 
expected.

Regards,
-Denis