From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH v0 2/2] hfp_hf_bluez5: Only register modems for Paired devices
Date: Wed, 30 Jan 2013 21:44:23 -0600 [thread overview]
Message-ID: <5109E897.2020800@gmail.com> (raw)
In-Reply-To: <1359563056-24294-2-git-send-email-claudio.takahasi@openbossa.org>
[-- Attachment #1: Type: text/plain, Size: 819 bytes --]
Hi Vinicius,
On 01/30/2013 10:24 AM, Claudio Takahasi wrote:
> From: Vinicius Costa Gomes<vinicius.gomes@openbossa.org>
>
> When there are many devices around that support the HFP AG profile,
> we may have a lot of modems that the user will never use.
> ---
> plugins/hfp_hf_bluez5.c | 61 +++++++++++++++++++++++++++++++++----------------
> 1 file changed, 41 insertions(+), 20 deletions(-)
>
Patch has been applied, however:
> - if (g_str_equal("Alias", name) == FALSE)
> + if (g_str_equal("Paired", name) == TRUE) {
> + modem_register_from_proxy(proxy, path);
> return;
> + }
This part looks suspicious in the case where Paired goes to false. If
BlueZ behaves in a certain way when the device is unpaired then I'd like
to see a comment here explaining that.
Regards,
-Denis
next prev parent reply other threads:[~2013-01-31 3:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-30 16:24 [PATCH v0 1/2] hfp_hf_bluez5: Improve Proxy property changed handling Claudio Takahasi
2013-01-30 16:24 ` [PATCH v0 2/2] hfp_hf_bluez5: Only register modems for Paired devices Claudio Takahasi
2013-01-31 3:44 ` Denis Kenzior [this message]
2013-01-31 12:12 ` Claudio Takahasi
2013-01-31 3:33 ` [PATCH v0 1/2] hfp_hf_bluez5: Improve Proxy property changed handling Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5109E897.2020800@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox