Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH v1 5/7] handsfree-audio: Call Agent "Release" when exiting
Date: Wed, 20 Feb 2013 21:29:33 -0600	[thread overview]
Message-ID: <5125949D.9010909@gmail.com> (raw)
In-Reply-To: <1361397351-5841-6-git-send-email-claudio.takahasi@openbossa.org>

[-- Attachment #1: Type: text/plain, Size: 733 bytes --]

Hi Claudio,

On 02/20/2013 03:55 PM, Claudio Takahasi wrote:
> This patch notifies the Agent implementation that it is no longer
> registered to the service daemon.
> ---
>   src/handsfree-audio.c | 15 ++++++++++++++-
>   1 file changed, 14 insertions(+), 1 deletion(-)
>

<snip>

> @@ -136,6 +147,8 @@ void __ofono_handsfree_audio_manager_cleanup(void)
>   	g_dbus_unregister_interface(ofono_dbus_get_connection(), "/",
>   						HFP_AUDIO_MANAGER_INTERFACE);
>
> -	if (agent)
> +	if (agent) {
> +		agent_release(agent);
>   		agent_free(agent);
> +	}
>   }

Please note that at this point the main loop has been stopped, so it is 
unlikely for this message to ever reach the recipient.

Regards,
-Denis

  reply	other threads:[~2013-02-21  3:29 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-19 20:44 [PATCH v0 00/11] Initial support for Handsfree Audio Manager Claudio Takahasi
2013-02-19 20:44 ` [PATCH v0 01/11] hfp_audio: Adds initial plugin files Claudio Takahasi
2013-02-19 20:44 ` [PATCH v0 02/11] ofono: Add option for experimental interfaces Claudio Takahasi
2013-02-20  0:20   ` Denis Kenzior
2013-02-20 14:52     ` Claudio Takahasi
2013-02-19 20:44 ` [PATCH v0 03/11] dbus: Move oFono error define to dbus.h Claudio Takahasi
2013-02-19 20:44 ` [PATCH v0 04/11] hfp_audio: Add initial manager methods declaration Claudio Takahasi
2013-02-20  0:44   ` Denis Kenzior
2013-02-20 14:55     ` Claudio Takahasi
2013-02-19 20:44 ` [PATCH v0 05/11] hfp_audio: Add "Register" agent arguments parsing Claudio Takahasi
2013-02-19 20:44 ` [PATCH v0 06/11] hfp_audio: Add codec array validation Claudio Takahasi
2013-02-19 20:44 ` [PATCH v0 07/11] hfp_audio: Add repeated Agent registration verification Claudio Takahasi
2013-02-20  0:39   ` Denis Kenzior
2013-02-20 14:53     ` Claudio Takahasi
2013-02-19 20:44 ` [PATCH v0 08/11] hfp_audio: Free agents when exiting Claudio Takahasi
2013-02-19 20:44 ` [PATCH v0 09/11] hfp_audio: Call Agent "Release" " Claudio Takahasi
2013-02-19 20:44 ` [PATCH v0 10/11] hfp_audio: Add Agent "Unregister" Claudio Takahasi
2013-02-19 20:44 ` [PATCH v0 11/11] hfp_audio: Add Agent tracking Claudio Takahasi
2013-02-20 21:55 ` [PATCH v1 0/7] Initial support for Handsfree Audio Manager Claudio Takahasi
2013-02-20 21:55   ` [PATCH v1 1/7] handsfree-audio: Add Manager registration Claudio Takahasi
2013-02-20 21:55   ` [PATCH v1 2/7] handsfree-audio: Add Agent "Register" method Claudio Takahasi
2013-02-20 21:55   ` [PATCH v1 3/7] handsfree-audio: Add codec array validation Claudio Takahasi
2013-02-20 21:55   ` [PATCH v1 4/7] handsfree-audio: Free agent when exiting Claudio Takahasi
2013-02-20 21:55   ` [PATCH v1 5/7] handsfree-audio: Call Agent "Release" " Claudio Takahasi
2013-02-21  3:29     ` Denis Kenzior [this message]
2013-02-20 21:55   ` [PATCH v1 6/7] handsfree-audio: Add Agent "Unregister" Claudio Takahasi
2013-02-20 21:55   ` [PATCH v1 7/7] handsfree-audio: Add Agent tracking Claudio Takahasi
2013-02-21  3:29   ` [PATCH v1 0/7] Initial support for Handsfree Audio Manager Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5125949D.9010909@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox