From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] handsfree-audio: Fix missing card index increment
Date: Tue, 26 Feb 2013 15:48:11 -0600 [thread overview]
Message-ID: <512D2D9B.7030801@gmail.com> (raw)
In-Reply-To: <1361914963-24197-1-git-send-email-claudio.takahasi@openbossa.org>
[-- Attachment #1: Type: text/plain, Size: 808 bytes --]
Hi Claudio,
On 02/26/2013 03:42 PM, Claudio Takahasi wrote:
> ---
> src/handsfree-audio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/handsfree-audio.c b/src/handsfree-audio.c
> index db65971..acd08e4 100644
> --- a/src/handsfree-audio.c
> +++ b/src/handsfree-audio.c
> @@ -165,7 +165,7 @@ int ofono_handsfree_card_register(struct ofono_handsfree_card *card)
> if (card == NULL)
> return -EINVAL;
>
> - snprintf(path, sizeof(path), "/card_%d", next_card_id);
> + snprintf(path, sizeof(path), "/card_%d", next_card_id++);
>
> if (!g_dbus_register_interface(ofono_dbus_get_connection(), path,
> HFP_AUDIO_CARD_INTERFACE,
Darn, I had to forget something :)
My own fix pushed that is a little bit more paranoid.
Regards,
-Denis
prev parent reply other threads:[~2013-02-26 21:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 21:42 [PATCH] handsfree-audio: Fix missing card index increment Claudio Takahasi
2013-02-26 21:48 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512D2D9B.7030801@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox