From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] Add vendor quirk for SIMCOM
Date: Thu, 28 Feb 2013 10:44:49 -0600 [thread overview]
Message-ID: <512F8981.1020401@gmail.com> (raw)
In-Reply-To: <1362066215-27452-2-git-send-email-r.r.zaripov@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 975 bytes --]
Hi Renat,
On 02/28/2013 09:43 AM, r.r.zaripov(a)gmail.com wrote:
> From: Renat Zaripov<r.r.zaripov@gmail.com>
>
> ---
> drivers/atmodem/gprs-context.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/atmodem/gprs-context.c b/drivers/atmodem/gprs-context.c
> index 3694c27..c5a0ae7 100644
> --- a/drivers/atmodem/gprs-context.c
> +++ b/drivers/atmodem/gprs-context.c
> @@ -208,7 +208,11 @@ static void at_cgdcont_cb(gboolean ok, GAtResult *result, gpointer user_data)
> return;
> }
>
> - sprintf(buf, "AT+CGDATA=\"PPP\",%u", gcd->active_context);
> + if (gcd->vendor == OFONO_VENDOR_SIMCOM)
> + memcpy(buf, "ATD*99#", 7);
At lease use strcpy, since you're not copying the '\0' here actually.
> + else
> + sprintf(buf, "AT+CGDATA=\"PPP\",%u", gcd->active_context);
> +
> if (g_at_chat_send(gcd->chat, buf, none_prefix,
> at_cgdata_cb, gc, NULL)> 0)
> return;
Regards,
-Denis
next prev parent reply other threads:[~2013-02-28 16:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-28 15:43 [PATCH] Add GPRS, mux, volume control support in SIMCOM sim900 modem module r.r.zaripov
2013-02-28 15:43 ` [PATCH] Add vendor quirk for SIMCOM r.r.zaripov
2013-02-28 16:44 ` Denis Kenzior [this message]
2013-02-28 16:42 ` [PATCH] Add GPRS, mux, volume control support in SIMCOM sim900 modem module Denis Kenzior
-- strict thread matches above, loose matches on Subject: below --
2013-03-12 14:40 [PATCH] Add vendor quirk for SIMCOM r.r.zaripov
2013-03-12 15:18 ` Viallard Anthony
2013-03-12 18:02 ` Denis Kenzior
2013-03-12 18:51 ` Renat Zaripov
2013-03-12 17:59 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512F8981.1020401@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox