Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCHv3 2/3] hfp_hf: Add generic hfp modem vendor
Date: Wed, 27 Mar 2013 00:09:28 -0500	[thread overview]
Message-ID: <51527F08.1090508@gmail.com> (raw)
In-Reply-To: <d928220c40964749f7c79822563087cdf3af74a1.1360663430.git.timo.mueller@bmw-carit.de>

[-- Attachment #1: Type: text/plain, Size: 691 bytes --]

Hi Timo,

On 02/13/2013 02:36 AM, Timo Mueller wrote:
> From: Timo Mueller<timo.mueller@bmw-carit.de>
>
> ---
>   drivers/hfpmodem/vendor.h    | 25 +++++++++++++++++++++++++
>   drivers/hfpmodem/voicecall.c |  3 +++
>   plugins/hfp_hf_bluez4.c      |  4 +++-
>   plugins/hfp_hf_bluez5.c      |  5 ++++-
>   4 files changed, 35 insertions(+), 2 deletions(-)
>   create mode 100644 drivers/hfpmodem/vendor.h
>

Please split up this patch in line with our patch submission guidelines. 
  Refer to HACKING, 'Submitting Patches' section.

I prefer this to be broken into four patches:
- vendor.h changes
- voicecall.c changes
- hfp_hf_bluez4 changes
- hfp_hf_bluez5 changes

  parent reply	other threads:[~2013-03-27  5:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-13  8:36 [PATCHv3 1/3] hfpmodem: Retry AT+CLCC request after outgoing callsetup Timo Mueller
2013-02-13  8:36 ` [PATCHv3 2/3] hfp_hf: Add generic hfp modem vendor Timo Mueller
2013-02-13  8:36   ` [PATCHv3 3/3] hfpmodem: Add N9 quirk to run CLCC after callheld=<2 or 3> Timo Mueller
2013-03-26  9:25     ` Timo =?unknown-8bit?q?M=C3=BCller?=
2013-03-27  5:13     ` Denis Kenzior
2013-03-27  5:09   ` Denis Kenzior [this message]
2013-03-27  5:05 ` [PATCHv3 1/3] hfpmodem: Retry AT+CLCC request after outgoing callsetup Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51527F08.1090508@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox