From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH v2 6/7] handsfree-audio: Set CVSD as default in the card
Date: Fri, 12 Apr 2013 18:14:02 -0500 [thread overview]
Message-ID: <5168953A.30200@gmail.com> (raw)
In-Reply-To: <1365622677-4824-6-git-send-email-vinicius.gomes@openbossa.org>
[-- Attachment #1: Type: text/plain, Size: 889 bytes --]
Hi Vinicius,
On 04/10/2013 02:37 PM, Vinicius Costa Gomes wrote:
> From: Claudio Takahasi<claudio.takahasi@openbossa.org>
>
> If the device doesn't support codec negotiation, the selected codec is
> not being initialized. For this case set CVSD as default.
> ---
> src/handsfree-audio.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/handsfree-audio.c b/src/handsfree-audio.c
> index 8fc6f93..a332f68 100644
> --- a/src/handsfree-audio.c
> +++ b/src/handsfree-audio.c
> @@ -342,6 +342,8 @@ struct ofono_handsfree_card *ofono_handsfree_card_create(unsigned int vendor,
>
> card = g_new0(struct ofono_handsfree_card, 1);
>
> + card->selected_codec = HFP_CODEC_CVSD;
> +
> card_list = g_slist_prepend(card_list, card);
>
> for (l = drivers; l; l = l->next) {
Please merge this patch with 'set_codec' implementation.
Regards,
-Denis
next prev parent reply other threads:[~2013-04-12 23:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 19:37 [PATCH v2 1/7] hfpmodem: Watch for changes in the selected codec Vinicius Costa Gomes
2013-04-10 19:37 ` [PATCH v2 2/7] include: ofono_handsfree_card_select_codec() Vinicius Costa Gomes
2013-04-12 23:12 ` Denis Kenzior
2013-04-13 23:34 ` Vinicius Costa Gomes
2013-04-10 19:37 ` [PATCH v2 3/7] handsfree-audio: Implement ofono_handsfree_card_select_codec() Vinicius Costa Gomes
2013-04-10 19:37 ` [PATCH v2 4/7] hfp_hf_bluez5: Set the audio codec in the card Vinicius Costa Gomes
2013-04-10 19:37 ` [PATCH v2 5/7] handsfree-audio: Send the selected codec Vinicius Costa Gomes
2013-04-10 19:37 ` [PATCH v2 6/7] handsfree-audio: Set CVSD as default in the card Vinicius Costa Gomes
2013-04-12 23:14 ` Denis Kenzior [this message]
2013-04-10 19:37 ` [PATCH v2 7/7] handsfree-audio: Enable wideband speech if defer is enabled Vinicius Costa Gomes
2013-04-12 23:16 ` Denis Kenzior
2013-04-12 23:07 ` [PATCH v2 1/7] hfpmodem: Watch for changes in the selected codec Denis Kenzior
2013-04-12 23:20 ` Vinicius Costa Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5168953A.30200@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox