From: Timo =?unknown-8bit?q?M=C3=BCller?= <mail@timomueller.eu>
To: ofono@ofono.org
Subject: Re: [PATCHv4 0/8] Nokia N9 specific quirks
Date: Mon, 15 Apr 2013 16:10:51 +0200 [thread overview]
Message-ID: <516C0A6B.6030409@timomueller.eu> (raw)
In-Reply-To: <cover.1364477353.git.timo.mueller@bmw-carit.de>
[-- Attachment #1: Type: text/plain, Size: 1762 bytes --]
Timo Mueller wrote, On 28.03.2013 14:36:
> From: Timo Mueller <timo.mueller@bmw-carit.de>
>
> Hi,
>
> this is the same as v3 with the changes suggested by Denis.
>
> v4 changes:
> * Retry CLCC request on outgoing callsetup is now a N9 specific quirk
> * Third patch has been split up according to HACKING rules
>
> The idea of setting the vendor during runtime was to use the "Model"
> string of the ofono_modem (analogous to what the wavecom modem
> does). But as the Nokia N9 does not support the device ID profile and
> the BT address has an OUI from Texas Instruments, I wasn't able to
> determine that the hfpmodem is a Nokia N9. Maybe you have some
> ideas on how this can be determined properly?
>
> As currently there's no functionality to detect the vendor of a
> hfpmodem on runtime the clcc quirk can be enabled for all vendors by
> patching the needs_callheld_clcc_quirk method.
>
> Regards,
> Timo
>
> Timo Mueller (8):
> hfpmodem: Add modem vendor stub
> hfpmodem: Add vendor header to makefile
> hfpmodem: Add vendor information to voicecall data
> hfp_hf_bluez4: Pass vendor on voicecall creation
> hfp_hf_bluez5: Pass vendor on voicecall creation
> hfpmodem: Add method to query if CLCC quirks are needed
> hfpmodem: Add N9 quirk for outgoing callsetup
> hfpmodem: Add N9 quirk for callheld=<2 or 3>
>
> Makefile.am | 3 +-
> drivers/hfpmodem/vendor.h | 26 +++++++++++++++
> drivers/hfpmodem/voicecall.c | 77 +++++++++++++++++++++++++++++++++++++++++---
> plugins/hfp_hf_bluez4.c | 4 ++-
> plugins/hfp_hf_bluez5.c | 5 ++-
> 5 files changed, 107 insertions(+), 8 deletions(-)
> create mode 100644 drivers/hfpmodem/vendor.h
>
Ping
next prev parent reply other threads:[~2013-04-15 14:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 13:36 [PATCHv4 0/8] Nokia N9 specific quirks Timo Mueller
2013-03-28 13:36 ` [PATCHv4 1/8] hfpmodem: Add modem vendor stub Timo Mueller
2013-03-28 13:36 ` [PATCHv4 2/8] hfpmodem: Add vendor header to makefile Timo Mueller
2013-03-28 13:36 ` [PATCHv4 3/8] hfpmodem: Add vendor information to voicecall data Timo Mueller
2013-03-28 13:36 ` [PATCHv4 4/8] hfp_hf_bluez4: Pass vendor on voicecall creation Timo Mueller
2013-03-28 13:36 ` [PATCHv4 5/8] hfp_hf_bluez5: " Timo Mueller
2013-03-28 13:37 ` [PATCHv4 6/8] hfpmodem: Add method to query if CLCC quirks are needed Timo Mueller
2013-03-28 13:37 ` [PATCHv4 7/8] hfpmodem: Add N9 quirk for outgoing callsetup Timo Mueller
2013-03-28 13:37 ` [PATCHv4 8/8] hfpmodem: Add N9 quirk for callheld=<2 or 3> Timo Mueller
2013-04-15 14:10 ` Timo =?unknown-8bit?q?M=C3=BCller?= [this message]
2013-05-08 8:30 ` [PATCHv4 0/8] Nokia N9 specific quirks Timo =?unknown-8bit?q?M=C3=BCller?=
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516C0A6B.6030409@timomueller.eu \
--to=mail@timomueller.eu \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox