From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/6] include: Add ofono_emulator_create_card()
Date: Thu, 25 Apr 2013 03:35:44 -0500 [thread overview]
Message-ID: <5178EAE0.8060208@gmail.com> (raw)
In-Reply-To: <1366823631-26262-2-git-send-email-paulo.borges@openbossa.org>
[-- Attachment #1: Type: text/plain, Size: 967 bytes --]
Hi Paulo,
On 04/24/2013 12:13 PM, Paulo Borges wrote:
> ---
> include/emulator.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/emulator.h b/include/emulator.h
> index 5cd894b..49168a1 100644
> --- a/include/emulator.h
> +++ b/include/emulator.h
> @@ -74,6 +74,8 @@ void ofono_emulator_register(struct ofono_emulator *em, int fd);
>
> void ofono_emulator_remove(struct ofono_emulator *em);
>
> +int ofono_emulator_create_card(struct ofono_emulator *em, int fd, int version);
> +
Why do you need the fd argument? It can be obtained from the
g_at_server object. e.g.
GIOChannel *channel = g_at_server_get_channel(server);
fd = g_io_channel_get_unix_fd(channel);
Also, what is the purpose of the version parameter?
> void ofono_emulator_send_final(struct ofono_emulator *em,
> const struct ofono_error *final);
> void ofono_emulator_send_unsolicited(struct ofono_emulator *em,
Regards,
-Denis
next prev parent reply other threads:[~2013-04-25 8:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 17:13 [PATCH 0/6] Add HandsfreeAudioCard to emulator Paulo Borges
2013-04-24 17:13 ` [PATCH 1/6] include: Add ofono_emulator_create_card() Paulo Borges
2013-04-25 8:35 ` Denis Kenzior [this message]
2013-04-25 17:36 ` Paulo Borges
2013-04-24 17:13 ` [PATCH 2/6] emulator: Implement ofono_emulator_create_card() Paulo Borges
2013-04-24 17:13 ` [PATCH 3/6] hfp_ag_bluez5: Create card when connect Paulo Borges
2013-04-24 17:13 ` [PATCH 4/6] emulator: Register card when establish SLC Paulo Borges
2013-04-24 17:13 ` [PATCH 5/6] emulator: Set local and remote address of card Paulo Borges
2013-04-24 17:13 ` [PATCH 6/6] hfp_ag_bluez5: Send fd to card creation Paulo Borges
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5178EAE0.8060208@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox