Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] fix ofonod crash when pin is blocked
Date: Thu, 12 Sep 2013 08:28:48 -0500	[thread overview]
Message-ID: <5231C190.4070302@gmail.com> (raw)
In-Reply-To: <DA62CA5DDF4CA640AA25B1684E5D141101D85F2F@SHSMSX102.ccr.corp.intel.com>

[-- Attachment #1: Type: text/plain, Size: 726 bytes --]

Hi Caiwen,

 >>
>> What is the real reason why the watchlist is NULL at the point in time this
>> function is being called?
>
> Yes, you are right. The correct comment should be "If at that time, "spn_watch" has been removed ofonod will crash due to
> "sim->spn_watches" is NULL."
>

Then please fix the patch description

> "spn_watch" is removed at "sim_free_main_state" function when SIM PIN is blocked. This is done before gprs/network atom is removed.
>

Then please fix the underlying issue itself.  Would signaling LOCKED_OUT 
state first before freeing the main state do the trick?


> About network registration status watch, the original comment is true.

Please elaborate.

Regards,
-Denis

      reply	other threads:[~2013-09-12 13:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-11 17:13 [PATCH] fix ofonod crash when pin is blocked caiwen.zhang
2013-09-11 18:01 ` Denis Kenzior
2013-09-12  0:53   ` Zhang, Caiwen
2013-09-12 13:28     ` Denis Kenzior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5231C190.4070302@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox