Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] plugins, mbpi: make mbpi return only APNs of a given type. When provisioning for internect connection, only OFONO_GPRS_CONTEXT_TYPE_INTERNET APNs will be returned.
Date: Fri, 11 Oct 2013 12:00:35 -0500	[thread overview]
Message-ID: <52582EB3.2040004@gmail.com> (raw)
In-Reply-To: <CACM4vuCbfXX75-tq4mY6JOv1YJ_TXzxOXuPJH+HL6HOfZy2vSQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1141 bytes --]

Hi Alfonso,

No top posting on this mailing list please.

 > No problem with splitting the patch.
>
> The patch is related to the following bug:
>
> https://bugs.launchpad.net/ubuntu/+source/ofono/+bug/1222106
>
> So we were obtaining some times settings for the MMS APN instead of the
> internet one. Maybe the change makes it work only for internet
> connection, but not for MMS. Would that mean that get_settings() should
> have a parameter specifying the context type so the user decides?
>

The mbpi parser will assign a context type to the provisioned context 
based on the "type" attribute inside mobile-broadband-provider-info.  So 
assuming the parser is working correctly, the context will be labeled 
accordingly in oFono on the D-Bus API level.

The parser works by returning all contexts that match a particular 
mcc/mnc if and only if no conflicts or multiple matches are found. 
Since you're saying it picks the 'wrong' one, then I assume the issue is 
inside your application, not oFono.

What does test/list-contexts output look like when you run the 
provisioning procedure?

Regards,
-Denis

  reply	other threads:[~2013-10-11 17:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-11  9:24 [PATCH] plugins, mbpi: make mbpi return only APNs of a given type. When provisioning for internect connection, only OFONO_GPRS_CONTEXT_TYPE_INTERNET APNs will be returned Alfonso Sanchez-Beato
2013-10-11 15:50 ` Denis Kenzior
2013-10-11 16:17   ` Alfonso Sanchez-Beato
2013-10-11 17:00     ` Denis Kenzior [this message]
2013-10-14  7:33       ` Alfonso Sanchez-Beato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52582EB3.2040004@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox