Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 0/8] hfpmodem: Add Apple Siri
Date: Wed, 18 Dec 2013 00:24:09 -0600	[thread overview]
Message-ID: <52B13F89.30103@gmail.com> (raw)
In-Reply-To: <1387216364-7138-1-git-send-email-krzysztofx.wilk@intel.com>

[-- Attachment #1: Type: text/plain, Size: 2149 bytes --]

Hi Krzysztof,

On 12/16/2013 11:52 AM, KrzysztofX Wilk wrote:
> This is an integration of the extended features for Apple devices which
> are connected via Bluetooth HFP. The plugin provides the Siri availability
> and the selection of Eyes Free Mode as defined in the following document:
> https://developer.apple.com/hardwaredrivers/bluetoothdesignguidelines.pdf
>
> KrzysztofX Wilk (8):
>    doc: Add Siri API
>    dbus: Define Siri DBUS Interface
>    include: Add Siri interface definition
>    siri: Add atom implementation
>    siri: Add atom driver
>    hfp_hf_bluez4: Enable Siri atom
>    hfp_hf_bluez5: Enable Siri atom
>    phonesim: Enable Siri atom
>
>   Makefile.am                 |  10 +-
>   doc/siri-api.txt            |  43 ++++++
>   drivers/hfpmodem/hfpmodem.c |   2 +
>   drivers/hfpmodem/hfpmodem.h |   3 +
>   drivers/hfpmodem/siri.c     | 215 ++++++++++++++++++++++++++++
>   include/dbus.h              |   1 +
>   include/siri.h              |  65 +++++++++
>   plugins/hfp_hf_bluez4.c     |   2 +
>   plugins/hfp_hf_bluez5.c     |   2 +
>   plugins/phonesim.c          |   2 +
>   src/ofono.h                 |   1 +
>   src/siri.c                  | 331 ++++++++++++++++++++++++++++++++++++++++++++
>   12 files changed, 673 insertions(+), 4 deletions(-)
>   mode change 100644 => 100755 Makefile.am
>   create mode 100644 doc/siri-api.txt
>   mode change 100644 => 100755 drivers/hfpmodem/hfpmodem.c
>   mode change 100644 => 100755 drivers/hfpmodem/hfpmodem.h
>   create mode 100755 drivers/hfpmodem/siri.c
>   create mode 100755 include/siri.h
>   mode change 100644 => 100755 plugins/hfp_hf_bluez4.c
>   mode change 100644 => 100755 plugins/hfp_hf_bluez5.c
>   mode change 100644 => 100755 plugins/phonesim.c
>   mode change 100644 => 100755 src/ofono.h
>   create mode 100755 src/siri.c
>

All patches have been applied.  I just fixed up a few minor whitespace 
issues and amended the patches.  Nothing of substance.

Thanks for doing this.  If you have time, would you mind adding a short 
blurb in doc/features.txt that mentions this feature?

Regards,
-Denis

      parent reply	other threads:[~2013-12-18  6:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-16 17:52 [PATCH 0/8] hfpmodem: Add Apple Siri KrzysztofX Wilk
2013-12-16 17:52 ` [PATCH 1/8] doc: Add Siri API KrzysztofX Wilk
2013-12-16 17:52 ` [PATCH 2/8] dbus: Define Siri DBUS Interface KrzysztofX Wilk
2013-12-16 17:52 ` [PATCH 3/8] include: Add Siri interface definition KrzysztofX Wilk
2013-12-16 17:52 ` [PATCH 4/8] siri: Add atom implementation KrzysztofX Wilk
2013-12-16 17:52 ` [PATCH 5/8] siri: Add atom driver KrzysztofX Wilk
2013-12-16 17:52 ` [PATCH 6/8] hfp_hf_bluez4: Enable Siri atom KrzysztofX Wilk
2013-12-16 17:52 ` [PATCH 7/8] hfp_hf_bluez5: " KrzysztofX Wilk
2013-12-16 17:52 ` [PATCH 8/8] phonesim: " KrzysztofX Wilk
2013-12-18  6:24 ` Denis Kenzior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B13F89.30103@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox