From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] gprs: Use "internet" apn for auto-created context
Date: Thu, 16 Jan 2014 21:43:39 -0600 [thread overview]
Message-ID: <52D8A6EB.90506@gmail.com> (raw)
In-Reply-To: <52D84681.6000706@jolla.com>
[-- Attachment #1: Type: text/plain, Size: 1824 bytes --]
Hi Slava,
A gentle reminder to please not top-post on this mailing list.
On 01/16/2014 02:52 PM, Slava Monich wrote:
> Hi Denis,
>
> Sorry to bother you, but I don't quite get the logic. There's something
> that needs to be done in case if ALL provisioning plugins have run and
> failed. How could that be a part of a provisioning plugin? They all have
> already run and failed by definition of the problem.
We do; we create an empty context to signify that provisioning has
failed. I do realize you mean well, but you're trying to wildly guess
(at least that is how I read the commit description) and breaking
existing behavior.
>
> And another thing. If context initialization belongs exclusively to the
> provisioning plugins then what is this add_context() call doing there?
> And why INTERNET context is created but, say, MMS is not? Isn't that a
> wild guess too? If so then I have found exactly the right place for
> another wild guess. Or am I missing something?
You are :) The special context is not meant to be used, and is by
design meant to always fail.
An empty APN is by definition invalid, so it is used as a 'special' flag
value. The 'special' empty APN context is used by various oFono UIs to
start a user-guided provisioning process. If you mess with this
behavior, you will break those UIs.
Why only an internet context is created is largely historical. This
behavior probably predates MMS contexts.
>
> I don't want to waste your time as well as mine by submitting patches
> that get rejected but in order to do so I have to understand why patches
> get rejected.
Completely understandable. Please feel free to start a conversation on
the mailing list or the IRC channel whenever you feel you need more
information.
Regards,
-Denis
next prev parent reply other threads:[~2014-01-17 3:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 14:43 [PATCH] gprs: Use "internet" apn for auto-created context Slava Monich
2014-01-16 17:04 ` Denis Kenzior
2014-01-16 20:52 ` Slava Monich
2014-01-17 3:43 ` Denis Kenzior [this message]
2014-01-19 10:25 ` Slava Monich
2014-01-20 3:12 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D8A6EB.90506@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox