Re: [PATCH] sim: Handle multiple invocations of sim_imsi_obtained

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1178 bytes --]

Hi Slava,

On 05/06/2014 06:54 AM, Slava Monich wrote:
> To avoid leaking memory and issuing unnecessary D-Bus signals
> ---
>  src/sim.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/src/sim.c b/src/sim.c
> index edae5eb..1b0cb80 100644
> --- a/src/sim.c
> +++ b/src/sim.c
> @@ -1425,11 +1425,18 @@ static void sim_set_ready(struct ofono_sim *sim)
>  
>  static void sim_imsi_obtained(struct ofono_sim *sim, const char *imsi)
>  {
> -	DBusConnection *conn = ofono_dbus_get_connection();
> -	const char *path = __ofono_atom_get_path(sim->atom);
> +	DBusConnection *conn;
> +	const char *path;
> +
> +	if (sim->imsi && !strcmp(sim->imsi, imsi))
> +		return;

Calling this function a second time is an error.  So this condition
looks highly suspect.  What issue are you trying to address?

>  
> +	DBG("%s", imsi);
> +	g_free(sim->imsi);
>  	sim->imsi = g_strdup(imsi);
>  
> +	conn = ofono_dbus_get_connection();
> +	path = __ofono_atom_get_path(sim->atom);
>  	ofono_dbus_signal_property_changed(conn, path,
>  						OFONO_SIM_MANAGER_INTERFACE,
>  						"SubscriberIdentity",
> 

Regards,
-Denis