From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 3/6] plugins: new driver for u-blox SARA-U270 modems
Date: Thu, 26 Jun 2014 10:35:11 -0500 [thread overview]
Message-ID: <53AC3DAF.304@gmail.com> (raw)
In-Reply-To: <20140626144934.GT33006@rincewind.trouble.is>
[-- Attachment #1: Type: text/plain, Size: 1215 bytes --]
Hi Philip,
On 06/26/2014 09:49 AM, Philip Paeps wrote:
> On 2014-06-26 09:29:51 (-0500), Denis Kenzior <denkenz@gmail.com> wrote:
>>> +static void ublox_remove(struct ofono_modem *modem)
>>> +{
>>> + struct ublox_data *data = ofono_modem_get_data(modem);
>>> +
>>> + DBG("%p", modem);
>>> +
>>> + ofono_modem_set_data(modem, NULL);
>>> + g_at_chat_unref(data->aux);
>>
>> Any reason data->modem is not being unrefed? e.g in the case of hot-unplug?
>
> As far as I can tell, disable is always called before remove. In the
> hot-unplug case, ofonod -d output goes:
>
> ofonod[680]: src/gprs.c:gprs_remove() atom: 0x1443220
> ofonod[680]: src/sim.c:sim_remove() atom: 0x1442fb0
> ofonod[680]: src/modem.c:devinfo_remove() atom: 0x14425a0
> ofonod[680]: plugins/ublox.c:ublox_disable() 0x143ba00
> ofonod[680]: plugins/ublox.c:ublox_remove() 0x143ba00
> ofonod[680]: src/modem.c:unregister_property() property 0x143bb00
> ofonod[680]: src/modem.c:unregister_property() property 0x14448e0
>
> Am I missing something?
>
ofono_modem_remove calls disable() only if the modem is powered. So in
cases of e.g. modem still being powered up, disable() won't be called.
Regards,
-Denis
next prev parent reply other threads:[~2014-06-26 15:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 17:10 [PATCH 0/6] Add a driver for u-blox modems Philip Paeps
2014-06-24 17:10 ` [PATCH 1/6] atmodem: add vendor u-blox Philip Paeps
2014-06-24 17:10 ` [PATCH 2/6] udevng: add detection logic for u-blox modems Philip Paeps
2014-06-24 17:10 ` [PATCH 3/6] plugins: new driver for u-blox SARA-U270 modems Philip Paeps
2014-06-26 14:29 ` Denis Kenzior
2014-06-26 14:49 ` Philip Paeps
2014-06-26 15:35 ` Denis Kenzior [this message]
2014-06-24 17:10 ` [PATCH 4/6] sim: query u-blox PIN retries with AT+UPINCNT Philip Paeps
2014-06-24 17:10 ` [PATCH 5/6] gprs: add support for u-blox +UREG URCs Philip Paeps
2014-06-24 17:10 ` [PATCH 6/6] atmodem: set the auth method for u-blox modems Philip Paeps
-- strict thread matches above, loose matches on Subject: below --
2014-06-26 18:28 [PATCH v2 0/6] Add a driver " Philip Paeps
2014-06-26 18:28 ` [PATCH 3/6] plugins: new driver for u-blox SARA-U270 modems Philip Paeps
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AC3DAF.304@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox