Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 0/2] Init handsfree audio manager only for Bluez5
Date: Mon, 02 Feb 2015 09:30:20 -0600	[thread overview]
Message-ID: <54CF980C.80508@gmail.com> (raw)
In-Reply-To: <1422880986-11262-1-git-send-email-tommi.kenakkala@tieto.com>

[-- Attachment #1: Type: text/plain, Size: 633 bytes --]

Hi Tommi,

On 02/02/2015 06:43 AM, Tommi Kenakkala wrote:
> Ofono should initialise Bluetooth handsfree SCO audio socket only
> with Bluez5, not with Bluez4.
> Here's one approach to work around the problem. Feel free to improve.
>
> Tommi Kenakkala (2):
>    main: Remove handsfree audio manager init and cleanup
>    handsfree-audio: Init and cleanup audio manager on ref/unref calls
>
>   src/handsfree-audio.c |   16 ++++++++--------
>   src/main.c            |    4 ----
>   2 files changed, 8 insertions(+), 12 deletions(-)
>

Looks good to me.  Applied after tweaking the commit messages.

Regards,
-Denis

      parent reply	other threads:[~2015-02-02 15:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-02 12:43 [PATCH 0/2] Init handsfree audio manager only for Bluez5 Tommi Kenakkala
2015-02-02 12:43 ` [PATCH 1/2] main: Remove handsfree audio manager init and cleanup Tommi Kenakkala
2015-02-02 12:43 ` [PATCH 2/2] handsfree-audio: Init and cleanup audio manager on ref/unref calls Tommi Kenakkala
2015-02-02 15:30 ` Denis Kenzior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54CF980C.80508@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox