From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/2] cinterion: Replace tc65 plugin with vendor generic cinterion plugin
Date: Fri, 01 May 2015 09:05:50 -0500 [thread overview]
Message-ID: <5543883E.4090900@gmail.com> (raw)
In-Reply-To: <1430420897-31084-2-git-send-email-ajlennon@dynamicdevices.co.uk>
[-- Attachment #1: Type: text/plain, Size: 999 bytes --]
Hi Alex,
On 04/30/2015 02:08 PM, Alex J Lennon wrote:
> On the basis that cinterion tx6x, ehsx, other devices will likely
> have similar firmware requirements, implement a generic cinterion
> plugin.
>
> The udev implementation retains support for "tc65" device for
> backwards compatibility, and adds support for "ehs6" and generic
> "cinterion" devices.
> ---
> Makefile.am | 4 +-
> plugins/cinterion.c | 249 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> plugins/tc65.c | 245 ---------------------------------------------------
Might be easier & cleaner to start off with this patch first. Copying
the virgin tc65.c to cinterion.c.
> plugins/udev.c | 11 ++-
Then add quirk handling in patch 1 and add ehs6 specific logic to
plugins/udev.c in follow on commits.
> 4 files changed, 259 insertions(+), 250 deletions(-)
> create mode 100644 plugins/cinterion.c
> delete mode 100644 plugins/tc65.c
>
Regards,
-Denis
next prev parent reply other threads:[~2015-05-01 14:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 19:08 [PATCH 1/2] cinterion: Add cinterion vendor support Alex J Lennon
2015-04-30 19:08 ` [PATCH 2/2] cinterion: Replace tc65 plugin with vendor generic cinterion plugin Alex J Lennon
2015-05-01 14:05 ` Denis Kenzior [this message]
2015-05-01 21:11 ` Alex J Lennon
2015-05-01 14:02 ` [PATCH 1/2] cinterion: Add cinterion vendor support Denis Kenzior
2015-05-12 17:27 ` Alex J Lennon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5543883E.4090900@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox