Hi Denis, On 01/05/2015 16:02, Denis Kenzior wrote: > Hi Alex, > > This part seems to be completely unnecessary? At least by my reading > of the code flow, at_cmer_set_cb is never called in the case of > OFONO_VENDOR_CINTERION. > > This is not our coding style. Please refer to doc/coding-style.txt > and the Linux Kernel coding style document here: > https://www.kernel.org/doc/Documentation/CodingStyle. I've removed the check to ensure that the callback is not re-registered accidentally and reformatted the patch-set, hopefully more in line with your suggestions as to flow... Thanks for the link to the ofono preferred coding style. I will make time in the near future to take a look at this. Best Regards, Alex