Re: [PATCH 07/10] ril: Remove asserts

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]

Hi Alfonso,

On 10/15/2015 11:47 AM, Alfonso Sanchez-Beato wrote:
> ---
>   plugins/ril.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/plugins/ril.c b/plugins/ril.c
> index e31f24b..2edb0a9 100644
> --- a/plugins/ril.c
> +++ b/plugins/ril.c
> @@ -144,7 +144,9 @@ static void ril_radio_state_changed(struct ril_msg *message, gpointer user_data)
>   			break;
>   		default:
>   			/* Malformed parcel; no radio state == broken rild */
> -			g_assert(FALSE);
> +			ofono_error("%s: Bad radio state (%d), exiting",
> +							__func__, radio_state);
> +			exit(1);

Can we just remove the ril modem in question instead of killing the 
entire daemon?

>   		}
>   	}
>   }
> @@ -213,7 +215,6 @@ void ril_pre_sim(struct ofono_modem *modem)
>   	sim_data.ril_state_watch = NULL;
>
>   	rd->sim = ofono_sim_create(modem, rd->vendor, RILMODEM, &sim_data);
> -	g_assert(rd->sim != NULL);
>   }
>
>   void ril_post_sim(struct ofono_modem *modem)
>

Regards,
-Denis