From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] src/log.c: Don't crash when addr2line output contains no newline
Date: Wed, 06 Apr 2016 13:22:28 -0500 [thread overview]
Message-ID: <570553E4.7050106@gmail.com> (raw)
In-Reply-To: <1459884174-66474-1-git-send-email-holger@freyther.de>
[-- Attachment #1: Type: text/plain, Size: 713 bytes --]
Hi Holger,
On 04/05/2016 02:22 PM, Holger Hans Peter Freyther wrote:
> From: Harald Welte <hwelte@sysmocom.de>
>
> Signed-off-by: Holger Hans Peter Freyther <hfreyther@sysmocom.de>
We don't use Signed-off-by. Do you want to resend or should I edit this
out before applying?
> ---
> src/log.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/log.c b/src/log.c
> index 6331b0d..42a2ec1 100644
> --- a/src/log.c
> +++ b/src/log.c
> @@ -192,6 +192,8 @@ static void print_backtrace(unsigned int offset)
> buf[len] = '\0';
>
> pos = strchr(buf, '\n');
> + if (!pos)
> + break;
> *pos++ = '\0';
>
> if (strcmp(buf, "??") == 0) {
>
Regards,
-Denis
next prev parent reply other threads:[~2016-04-06 18:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 19:22 [PATCH] src/log.c: Don't crash when addr2line output contains no newline Holger Hans Peter Freyther
2016-04-06 18:22 ` Denis Kenzior [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-04-16 15:28 Holger Hans Peter Freyther
2016-04-18 15:02 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570553E4.7050106@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox