From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] plugins: Add allowed APN list
Date: Wed, 20 Apr 2016 10:07:24 -0500 [thread overview]
Message-ID: <57179B2C.7060608@gmail.com> (raw)
In-Reply-To: <1461122890-7163-1-git-send-email-nishanth.v@intel.com>
[-- Attachment #1: Type: text/plain, Size: 942 bytes --]
Hi Nishanth,
On 04/19/2016 10:28 PM, Nishanth V wrote:
> ---
> Makefile.am | 9 +-
> doc/allowed-apns-api.txt | 17 +++
> plugins/allowed-apns.c | 272 ++++++++++++++++++++++++++++++++++++++++
> src/simutil.c | 1 +
> test/list-allowed-access-points | 25 ++++
> 5 files changed, 322 insertions(+), 2 deletions(-)
> create mode 100644 doc/allowed-apns-api.txt
> create mode 100644 plugins/allowed-apns.c
> create mode 100755 test/list-allowed-access-points
>
Looks good, but please submit this as a series. Remember our patch
submission guidelines can be found in HACKING 'Submitting patches' section.
So:
- one patch for doc/allowed-apns-api.txt + makefile specific changes
- one patch for simutil.c changes
- one patch for the plugin + required makefile changes
- one patch for test script + required makefile makefile
Regards,
-Denis
prev parent reply other threads:[~2016-04-20 15:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 3:28 [PATCH] plugins: Add allowed APN list Nishanth V
2016-04-20 15:07 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57179B2C.7060608@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox