From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/5] modem: clean up atoms on modem_unregister
Date: Fri, 22 Apr 2016 14:25:15 -0500 [thread overview]
Message-ID: <571A7A9B.3010806@gmail.com> (raw)
In-Reply-To: <1461330431-20206-2-git-send-email-john.ernberg@actia.se>
[-- Attachment #1: Type: text/plain, Size: 826 bytes --]
Hi John,
On 04/22/2016 08:07 AM, John Ernberg wrote:
> From: John Ernberg <john.ernberg@actia.se>
>
> This resolves a crash that can happen when a e.g. usb modem is removed.
> ---
> src/modem.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/modem.c b/src/modem.c
> index a89fa48..4968839 100644
> --- a/src/modem.c
> +++ b/src/modem.c
> @@ -2071,6 +2071,9 @@ static void modem_unregister(struct ofono_modem *modem)
> if (modem->powered == TRUE)
> set_powered(modem, FALSE);
>
So in theory, set_powered calls flush_atoms...
> + if (modem->atoms)
> + flush_atoms(modem, MODEM_STATE_POWER_OFF);
> +
So why is this needed?
Do you have a stack trace handy?
> __ofono_watchlist_free(modem->atom_watches);
> modem->atom_watches = NULL;
>
>
Regards,
-Denis
next prev parent reply other threads:[~2016-04-22 19:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 13:07 [PATCH 0/5] Clean up atoms on modem_unregister John Ernberg
2016-04-22 13:07 ` [PATCH 1/5] modem: clean " John Ernberg
2016-04-22 13:07 ` [PATCH 2/5] bluez4: track and clean up atom watches John Ernberg
2016-04-22 13:07 ` [PATCH 3/5] bluez5: " John Ernberg
2016-04-22 13:07 ` [PATCH 4/5] push notification: " John Ernberg
2016-04-22 13:07 ` [PATCH 5/5] smart messaging: " John Ernberg
2016-04-22 19:43 ` [PATCH 4/5] push notification: " Denis Kenzior
2016-04-25 7:02 ` John Ernberg
2016-04-25 18:56 ` Denis Kenzior
2016-04-26 6:03 ` John Ernberg
2016-04-22 19:25 ` Denis Kenzior [this message]
2016-04-25 6:55 ` [PATCH 1/5] modem: clean up atoms on modem_unregister John Ernberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571A7A9B.3010806@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox