Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: AT channel problem
Date: Thu, 05 May 2016 10:10:48 -0500	[thread overview]
Message-ID: <572B6278.7050806@gmail.com> (raw)
In-Reply-To: <CAH4ZQwv2U6yYnNmE8+DseJyPf2KFuj1AXBA1NCqoptk5GN_iNA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 902 bytes --]

Hi Enrico,

 > Anyway, I managed to solve the problem with a simple yet potentially
> dangerous fix: I deleted the if statement in the
> GSM_PERMISSIVE_STATE_RESPONSE_STRING case, so, it changed from:
>
> ​gatchat/gatsyntax.c (row 309 more or less)​
> case GSM_PERMISSIVE_STATE_RESPONSE_STRING:
>      if (byte == '"')
> syntax->state = GSM_PERMISSIVE_STATE_RESPONSE;
> break;​
>
> ​To:
>
> ​case GSM_PERMISSIVE_STATE_RESPONSE_STRING:
> syntax->state = GSM_PERMISSIVE_STATE_RESPONSE;
> break;​
>
> ​With this fix everything seem to work in my case.
> Do you think it is dangerous in any way?​

Yes.  This particular logic enables strings (e.g. text enclosed in 
quotes) to contain various special characters that would otherwise be 
interpreted differently.

It looks like you have an unterminated " in one of the AT command 
responses...

Regards,
-Denis

  reply	other threads:[~2016-05-05 15:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-05  8:42 AT channel problem Enrico Sau
2016-05-05 14:04 ` Denis Kenzior
2016-05-05 14:51   ` Enrico Sau
2016-05-05 15:10     ` Denis Kenzior [this message]
2016-05-05 15:52       ` Enrico Sau
2016-05-06 10:06         ` Enrico Sau
2016-05-06 15:48           ` Denis Kenzior
2016-05-09  7:43             ` Enrico Sau
2016-05-09  8:22               ` Enrico Sau
2016-05-09 14:19               ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=572B6278.7050806@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox