Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] ubloxmodem: gprscontext: adapt for newer firmware
Date: Wed, 16 Nov 2016 11:52:18 -0600	[thread overview]
Message-ID: <582C9CD2.4000403@gmail.com> (raw)
In-Reply-To: <1479311662-12996-1-git-send-email-dragos@endocode.com>

[-- Attachment #1: Type: text/plain, Size: 866 bytes --]

Hi Dragos,

On 11/16/2016 09:54 AM, Dragos Tatulea wrote:
> The U-Blox documentation specifies the following:
> * get interface ip and dns from +CGDCONTRDP
> * get gw ip and netmask from +UIPADDR
>
> However, different firmware versions have different befaviour:
>
> * On newer firmware, +UIPADDR returns error. But it's possible to configure
> gateway ip == ipterface ip (read from CGDCONTRDP).
>
> * On older firmware, we can actually use the commands specified in the
> docs.
>
> This patch runs +CGDCONTRDP, configures everything and then tries to run
> +UIPADDR. In that works, reconfigures gw ip and netmask.
> ---
>   drivers/ubloxmodem/gprs-context.c | 51 +++++++++++++++++++++++++++++++++++++++
>   1 file changed, 51 insertions(+)
>

Amended the patch for a couple of small whitespace issues.  Applied, thanks!

Regards,
-Denis


      reply	other threads:[~2016-11-16 17:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-16 15:54 [PATCH] ubloxmodem: gprscontext: adapt for newer firmware Dragos Tatulea
2016-11-16 17:52 ` Denis Kenzior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=582C9CD2.4000403@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox