From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] smsutil: Fix receiving UTF-16 encoded messages with split 4-byte char
Date: Fri, 18 Nov 2016 09:35:29 -0600 [thread overview]
Message-ID: <582F1FC1.2060305@gmail.com> (raw)
In-Reply-To: <1479471439-18482-1-git-send-email-slava.monich@jolla.com>
[-- Attachment #1: Type: text/plain, Size: 543 bytes --]
Hi Slava,
On 11/18/2016 06:17 AM, Slava Monich wrote:
> The spec supports UCS2, but in reality UTF-16 is used, which supports
> 4-byte characters, which could be split into different message
> fragments. Accumulate the entire UTF-16 message before converting to
> UTF8.
>
> Author: Martin Jones <martin.jones@jolla.com>
> ---
> src/smsutil.c | 30 ++++++++++++++++++++++++++----
> 1 file changed, 26 insertions(+), 4 deletions(-)
>
Applied, thanks. It'd be nice to have a unit test for this as well.
Regards,
-Denis
prev parent reply other threads:[~2016-11-18 15:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 12:17 [PATCH] smsutil: Fix receiving UTF-16 encoded messages with split 4-byte char Slava Monich
2016-11-18 15:35 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=582F1FC1.2060305@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox