Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: MaxLyubimov <m.lyubimov@aqsi.ru>, ofono@lists.linux.dev
Cc: Sergei Golubtsov <sg@aqsi.ru>
Subject: Re: [PATCH 01/15] Skipping AT+CUAD sending for QUECTEL_EC2X vendor
Date: Wed, 18 Oct 2023 20:28:59 -0500	[thread overview]
Message-ID: <62d170cb-151d-4f72-81b8-419bede2c990@gmail.com> (raw)
In-Reply-To: <20231017104902.717947-1-m.lyubimov@aqsi.ru>

Hi Max,

On 10/17/23 05:48, MaxLyubimov wrote:
> From: Sergei Golubtsov <sg@aqsi.ru>
> 
> This workarounds bug in EC200A firmware which leads to modem
> reset in case of usage of some SIM cards when sending the next
> command
> ---
>   drivers/atmodem/sim.c | 10 +++++++++-
>   1 file changed, 9 insertions(+), 1 deletion(-)
> 

<snip>

> +
> +	/* QUECTEL EC2X reboots when executing the AT+CUAD command with SIM cards
> +	of some operators */

Note doc/coding-style.txt item M2.  Also note that this line is > 80 chars.  I 
fixed this for you.

> +	if (sd->vendor == OFONO_VENDOR_QUECTEL_EC2X)
> +		goto error;
> +
> +	cbd = cb_data_new(cb, data);
>   
>   	if (g_at_chat_send(sd->chat, "AT+CUAD", cuad_prefix,
>   			at_discover_apps_cb, cbd, g_free) > 0)

Applied, thanks.

Regards,
-Denis


      parent reply	other threads:[~2023-10-19  1:29 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-17 10:48 [PATCH 01/15] Skipping AT+CUAD sending for QUECTEL_EC2X vendor MaxLyubimov
2023-10-17 10:48 ` [PATCH 02/15] drivers: adding support for the SIMCom A7605E-H MaxLyubimov
2023-10-19  1:30   ` Denis Kenzior
2023-10-27  7:52     ` Любимов Максим
2023-10-29 21:16       ` Denis Kenzior
2023-10-17 10:48 ` [PATCH 03/15] plugins: " MaxLyubimov
2023-10-19  1:42   ` Denis Kenzior
2023-10-27  9:01     ` Любимов Максим
2023-10-29 20:41       ` Denis Kenzior
2023-10-30  7:11         ` Любимов Максим
2023-10-17 10:48 ` [PATCH 04/15] build: " MaxLyubimov
2023-10-17 10:48 ` [PATCH 05/15] drivers: quectel: Add radio settings MaxLyubimov
2023-10-19  1:49   ` Denis Kenzior
2023-10-17 10:48 ` [PATCH 06/15] build: Add quectel radio settings rules MaxLyubimov
2023-10-17 10:48 ` [PATCH 07/15] plugins: quectel: Add radio settings MaxLyubimov
2023-10-19  2:00   ` Denis Kenzior
2023-10-17 10:48 ` [PATCH 08/15] drivers: gemalto: Add models list MaxLyubimov
2023-10-17 10:48 ` [PATCH 09/15] plugins: gemalto: Include " MaxLyubimov
2023-10-17 10:48 ` [PATCH 10/15] plugins: udevng: Add support gemalto EHS5-E MaxLyubimov
2023-10-17 10:48 ` [PATCH 11/15] gemalto: radio-settings: Add support EHS5-E MaxLyubimov
2023-10-17 10:48 ` [PATCH 12/15] Fix PPP LCP Configure-Reject MaxLyubimov
2023-10-19  2:08   ` Denis Kenzior
2023-10-17 10:49 ` [PATCH 13/15] atmodem: added context deactivation event handling MaxLyubimov
2023-10-19  2:13   ` Denis Kenzior
2023-10-17 10:49 ` [PATCH 14/15] gatchat: added command completion by timeout MaxLyubimov
2023-10-19  2:21   ` Denis Kenzior
2023-10-27  9:45     ` Любимов Максим
2023-10-29 20:59       ` Denis Kenzior
2023-10-30  7:04         ` Любимов Максим
2023-10-30 14:29           ` Denis Kenzior
2023-10-17 10:49 ` [PATCH 15/15] ppp: message tracing MaxLyubimov
2023-10-19  2:22   ` Denis Kenzior
2023-10-27 10:01     ` Любимов Максим
2023-10-29 21:05       ` Denis Kenzior
2023-10-30  6:34         ` Любимов Максим
2023-10-30 14:30           ` Denis Kenzior
2023-10-19  1:28 ` Denis Kenzior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62d170cb-151d-4f72-81b8-419bede2c990@gmail.com \
    --to=denkenz@gmail.com \
    --cc=m.lyubimov@aqsi.ru \
    --cc=ofono@lists.linux.dev \
    --cc=sg@aqsi.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox