Open Source Telephony
 help / color / mirror / Atom feed
From: Benoit Monin <benoit.monin@laposte.net>
To: ofono@ofono.org
Subject: hso : swap username and password for PAP
Date: Tue, 22 Jun 2010 09:16:58 +0000	[thread overview]
Message-ID: <7342887.98669.1277198212796.JavaMail.www@wwinf8402> (raw)
In-Reply-To: <25118539.98442.1277198076995.JavaMail.www@wwinf8402>

[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]



The parameters for the AT command AT$QCPDPP must be swapped for PAP in order
to make it work with an Option modem. Tested with a GTM382 development kit.
No idea about CHAP parameters, left unchanged.

Signed-off-by: Benoît Monin 
---
drivers/hsomodem/gprs-context.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/hsomodem/gprs-context.c b/drivers/hsomodem/gprs-context.c
index 08c662f..87b6a09 100644
--- a/drivers/hsomodem/gprs-context.c
+++ b/drivers/hsomodem/gprs-context.c
@@ -166,7 +166,7 @@ static void hso_gprs_activate_primary(struct ofono_gprs_context *gc,

if (ctx->username[0] && ctx->password[0])
snprintf(buf, sizeof(buf), "AT$QCPDPP=%u,1,\"%s\",\"%s\"",
- ctx->cid, ctx->username, ctx->password);
+ ctx->cid, ctx->password, ctx->username);
else if (ctx->password[0])
snprintf(buf, sizeof(buf), "AT$QCPDPP=%u,2,,\"%s\"",
ctx->cid, ctx->password);
--





Une messagerie gratuite, garantie à vie et des services en plus, ça vous tente ?
Je crée ma boîte mail www.laposte.net


      parent reply	other threads:[~2010-06-22  9:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-22  9:14 Option (hso) modem and PAP Benoit Monin
2010-06-22  9:16 ` Set username and password with create-context Benoit Monin
2010-06-22  9:16 ` Benoit Monin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7342887.98669.1277198212796.JavaMail.www@wwinf8402 \
    --to=benoit.monin@laposte.net \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox