From: Adam Pigg <piggz1@gmail.com>
To: ofono@lists.linux.dev, Denis Kenzior <denkenz@gmail.com>
Subject: Re: Possible ofono patches
Date: Sat, 16 Mar 2024 10:41:28 +0000 [thread overview]
Message-ID: <7481802.MGcBpxfIA8@adam-laptop-hp> (raw)
In-Reply-To: <472c1fd1-45c4-4721-a0df-76a60ccc3944@gmail.com>
Hi Denis
On Friday, 15 March 2024 13:56:00 GMT Denis Kenzior wrote:
> Hi Adam,
>
> On 3/13/24 02:59, piggz1@gmail.com wrote:
> > Hi all
> >
> > A few weeks ago, i started a personal project to try to rebase the jolla
> > ofonalo dbus api's and changes ontop of current ofono. I am writing
> > about it here https://www.piggz.co.uk/sites/pgz/blog
> Nice!
>
> > My current work is against 2.5 with patches that are somewhat working with
> > my pinephone. My tree of individual patches is available at
> > https://github.com/piggz/ofono-upstream/tree/main/rpm
> >
> > I wondered if anyone would care to scan over them and provide feedback as
> > to whether any are suitable to upatream into ofono. I appreciate not all
> > will be, but with some rework, others may be of interest.
> Hard to say since the commits lack any context information for _why_ the
> given code exists and what problem it is trying to solve. Perhaps Jolla
> can help with that?
>
> Also, I'd like to eradicate the use of glib in favor of ell in oFono,
> starting with qmi modem driver (which is now 99.9% glib free). To this
> end, my preference is not to accept any new code that is glib based unless
> there's a strong reason to do so.
>
> > There is a working voicecall implementation for qmimodem, which includes a
> > refactored call-list implementation. Many of the others add dbus
> > interfaces for sailfish so may not be interesting.
> The voicecall driver is definitely something I'd take upstream and can help
> shepherd along.
>
I thought this would be most likely. I do some re-work on it and make sure
there is no glib before I submit it to the ML.
Currently it seems to be working for me, at least when in 2g or 3g mode.
Calls fail in 4g, i think because the connection needs to be downgraded at
this point.
> Regards,
> -Denis
prev parent reply other threads:[~2024-03-16 10:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 7:59 Possible ofono patches piggz1
2024-03-15 13:56 ` Denis Kenzior
2024-03-16 10:41 ` Adam Pigg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7481802.MGcBpxfIA8@adam-laptop-hp \
--to=piggz1@gmail.com \
--cc=denkenz@gmail.com \
--cc=ofono@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox