From: Kalle Valo <kalle.valo@canonical.com>
To: ofono@ofono.org
Subject: Re: commit "Fix Use hashtable to record udev path" breaks huawei
Date: Thu, 20 May 2010 08:13:55 +0300 [thread overview]
Message-ID: <87aarv6tpo.fsf@potku.valot.fi> (raw)
In-Reply-To: <33AB447FBD802F4E932063B962385B351E8DD24D@shsmsx501.ccr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1091 bytes --]
"Zhang, Zhenhua" <zhenhua.zhang@intel.com> writes:
> Hi Kalle,
Hi Zhenhua,
> Kalle Valo wrote:
>> Kalle Valo <kalle.valo@canonical.com> writes:
>>
>>> while working on third version of my huawei gprs patches I noticed
>>> that this commit breaks huawei:
>>>
>>> commit af976f7e524746b1b55645967e11ab8250f593a8
>>> Author: Zhenhua Zhang <zhenhua.zhang@intel.com>
>>> Date: Tue May 11 09:04:28 2010 +0800
[...]
>> Sorry, I was too hasty. The patch is fine, I was just testing
>> inproperly. After a bit more testing I found out that problem
>> always happens when I plugin the usb modem:
>>
[...]
> My commit af976f7e524 should not impact modem detection and power up
> stage. If you found huawei modem still exists in oFono after you
> unplug the dungle, I guess something maybe wrong in my patch. :-)
Your patch is fine, I was just testing inproperly. I didn't use the
exactly the same test steps when I did the revert/unrevert cycle of your
patch, and that's why I falsely assumed that your patch broke it. Sorry
about that.
--
Kalle Valo
prev parent reply other threads:[~2010-05-20 5:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 13:19 commit "Fix Use hashtable to record udev path" breaks huawei Kalle Valo
2010-05-19 15:23 ` Kalle Valo
2010-05-19 13:55 ` Denis Kenzior
2010-05-20 1:18 ` Zhang, Zhenhua
2010-05-20 5:13 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87aarv6tpo.fsf@potku.valot.fi \
--to=kalle.valo@canonical.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox