From: Kalle Valo <kalle.valo@canonical.com>
To: ofono@ofono.org
Subject: Re: [PATCH v2] atmodem: fix crash during context deactivation
Date: Wed, 26 May 2010 18:33:47 +0300 [thread overview]
Message-ID: <87d3wik78k.fsf@potku.valot.fi> (raw)
In-Reply-To: <33AB447FBD802F4E932063B962385B351E99720A@shsmsx501.ccr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 567 bytes --]
"Zhang, Zhenhua" <zhenhua.zhang@intel.com> writes:
> Hi Valo,
Hi Zhenhua,
> Kalle Valo wrote:
>> - channel = g_at_chat_get_channel(gcd->chat);
>> - g_at_chat_unref(gcd->chat);
>> + g_at_chat_suspend(gcd->chat);
>>
>> /* open ppp */
>> - gcd->ppp = g_at_ppp_new(channel);
>> + gcd->ppp = g_at_ppp_new_from_io(io);
>>
>> if (gcd->ppp == NULL)
>> return FALSE;
>
> You should use g_at_chat_resume(gcd->chat) to resume the chat before
> you returns FALSE here.
Good point. I just sent v3, but I'll send v4 immeadiately.
--
Kalle Valo
prev parent reply other threads:[~2010-05-26 15:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-25 14:56 [PATCH v2] atmodem: fix crash during context deactivation Kalle Valo
2010-05-26 7:05 ` Kalle Valo
2010-05-26 8:35 ` Marcel Holtmann
2010-05-26 15:06 ` Kalle Valo
2010-05-26 15:04 ` Zhang, Zhenhua
2010-05-26 15:33 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d3wik78k.fsf@potku.valot.fi \
--to=kalle.valo@canonical.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox