From mboxrd@z Thu Jan  1 00:00:00 1970
Content-Type: multipart/mixed; boundary="===============8323343453001594128=="
MIME-Version: 1.0
From: Kalle Valo <kalle.valo@canonical.com>
Subject: Re: [PATCH 1/1] Huawei E176: Mark primary and secondary device at
 ofono.rules TODO: Fix sim_add detection, add E1552 idProduct to ofono.rules
Date: Mon, 31 May 2010 15:29:43 +0300
Message-ID: <87hblo2r0o.fsf@potku.valot.fi>
In-Reply-To: <20100530134721.GA14827@h02.hostsharing.net>
List-Id: <ofono.ofono.org>
To: ofono@ofono.org

--===============8323343453001594128==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

Hi Florian,

thank you for the patch.

I'm curious, did you test ofono with Huawei E176? Did it work? Did you
have any problems?

Florian Steinel <Florian.Steinel@gmail.com> writes:

> diff --git a/plugins/ofono.rules b/plugins/ofono.rules
> index 0575362..abae06a 100644
> --- a/plugins/ofono.rules
> +++ b/plugins/ofono.rules
> @@ -1,11 +1,26 @@
>  # do not edit this file, it will be overwritten on update
>  =

>  ACTION!=3D"add|change", GOTO=3D"ofono_end"
> +
> +SUBSYSTEM!=3D"tty", GOTO=3D"ofono_typ_end"
> +KERNEL!=3D"ttyUSB[0-9]*", GOTO=3D"ofono_typ_end"
> +
> +# HUAWEI E176
> +ENV{ID_VENDOR_ID}=3D=3D"12d1", ENV{ID_MODEL_ID}=3D=3D"1003", ENV{ID_IFAC=
E}=3D=3D"00", ENV{OFONO_TYP}=3D"PRIMARY"
> +ENV{ID_VENDOR_ID}=3D=3D"12d1", ENV{ID_MODEL_ID}=3D=3D"1003", ENV{ID_IFAC=
E}=3D=3D"01", ENV{OFONO_TYP}=3D"SECONDARY"
>
> +# HUAWEI E1552
> +# TODO: Add ID_MODEL_ID aka idProduct for E1552
> +#ENV{ID_VENDOR_ID}=3D=3D"12d1", ENV{ID_MODEL_ID}=3D=3D"1003", ENV{ID_IFA=
CE}=3D=3D"00", ENV{OFONO_TYP}=3D"PRIMARY"
> +#ENV{ID_VENDOR_ID}=3D=3D"12d1", ENV{ID_MODEL_ID}=3D=3D"1003", ENV{ID_IFA=
CE}=3D=3D"02", ENV{OFONO_TYP}=3D"SECONDARY"
> +
> +LABEL=3D"ofono_typ_end"

I think adding usb ids to the rules file for each Huawei product is a
maintenance problem. There are so many devices out there, that handling
the usb ids for all of them is difficult.

I personally would prefer a solution which would dynamically probe the
ports and choose them based on results. I believe modemmanager does
something like this, but I haven't looked in detail.

But Denis and Marcel should comment here, they know best.

-- =

Kalle Valo

--===============8323343453001594128==--