From: Kalle Valo <kalle.valo@canonical.com>
To: ofono@ofono.org
Subject: Re: [PATCH v3] Fix busylooped in ppp_disconnect for huawei modem
Date: Wed, 04 Aug 2010 15:54:48 +0300 [thread overview]
Message-ID: <87k4o6wnaf.fsf@potku.valot.fi> (raw)
In-Reply-To: <4C5718F4.8040001@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 928 bytes --]
Denis Kenzior <denkenz@gmail.com> writes:
> Hi Zhenhua,
>
> On 07/27/2010 07:25 PM, Zhenhua Zhang wrote:
>> Huawei modem closes the modem port after PPP disconnect. So the channel
>> of gatchat is NULL in ppp_disconnect. In such case, we resume the chat
>> and it causes huawei_disconnect() get called and the gprs context is
>> removed later.
>>
>> Before removing this gprs context, we should reply the pending DBus
>> message to the client.
>> ---
>
> Since V2 was reported to work I went ahead and applied this version.
> Thanks for the fix.
I quickly tested current git (which should contain this patch) with
Huawei E1552 and ofono doesn't crash anymore. But now ofono doesn't
connect after a few rounds of connect, disconnect, connect, disconnect
testing. I need to unplug and plug in my modem to get it working again.
I don't know if this patch caused the regression or not.
--
Kalle Valo
prev parent reply other threads:[~2010-08-04 12:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-28 0:25 [PATCH v3] Fix busylooped in ppp_disconnect for huawei modem Zhenhua Zhang
2010-08-02 19:13 ` Denis Kenzior
2010-08-04 12:54 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k4o6wnaf.fsf@potku.valot.fi \
--to=kalle.valo@canonical.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox