From: Kalle Valo <kalle.valo@canonical.com>
To: ofono@ofono.org
Subject: Re: [PATCH v2] Fix busylooped in ppp_disconnect for huawei modem
Date: Tue, 27 Jul 2010 22:45:14 +0300 [thread overview]
Message-ID: <87pqy8k8tx.fsf@potku.valot.fi> (raw)
In-Reply-To: <1280206726-2133-1-git-send-email-zhenhua.zhang@intel.com>
[-- Attachment #1: Type: text/plain, Size: 638 bytes --]
Zhenhua Zhang <zhenhua.zhang@intel.com> writes:
> Huawei modem closes the modem port after PPP disconnect. So the channel
> of gatchat is NULL in ppp_disconnect. In such case, we resume the chat
> and it causes huawei_disconnect() get called and the gprs context is
> removed later.
>
> Before removing this gprs context, we should reply the pending DBus
> message to the client.
I tested the patch with my Huawei E1552 and it worked perfectly. Earlier
it was very easy to trigger the crash. I even tried some of my evil
tests and found no issues.
Tested-by: Kalle Valo <kalle.valo@canonical.com> :-)
--
Kalle Valo
prev parent reply other threads:[~2010-07-27 19:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-27 4:58 [PATCH v2] Fix busylooped in ppp_disconnect for huawei modem Zhenhua Zhang
2010-07-27 16:57 ` Denis Kenzior
2010-07-27 19:45 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pqy8k8tx.fsf@potku.valot.fi \
--to=kalle.valo@canonical.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox