From: Neil Jerram <neil@ossau.uklinux.net>
To: ofono@ofono.org
Subject: Re: [PATCH] ctm: use ofono_error instead of DBG for errors
Date: Wed, 15 Dec 2010 21:23:20 +0000 [thread overview]
Message-ID: <87zks6d92v.fsf@ossau.uklinux.net> (raw)
In-Reply-To: <1292447213-16751-1-git-send-email-padovan@profusion.mobi>
[-- Attachment #1: Type: text/plain, Size: 363 bytes --]
"Gustavo F. Padovan" <padovan@profusion.mobi> writes:
> [PATCH] ctm: use ofono_error instead of DBG for errors
I'm a newcomer to ofono, and to this list, but in general I'd hope to
see more explanation/justification of code changes than this patch
provides. In other words, why is it better to use ofono_error instead
of DBG?
Regards,
Neil
next prev parent reply other threads:[~2010-12-15 21:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 21:06 [PATCH] ctm: use ofono_error instead of DBG for errors Gustavo F. Padovan
2010-12-15 21:23 ` Neil Jerram [this message]
2010-12-15 21:47 ` Gustavo F. Padovan
2010-12-15 22:00 ` Neil Jerram
2010-12-16 14:47 ` Lucas De Marchi
2010-12-16 18:04 ` [PATCH] " Gustavo F. Padovan
2010-12-17 16:29 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zks6d92v.fsf@ossau.uklinux.net \
--to=neil@ossau.uklinux.net \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox