From mboxrd@z Thu Jan  1 00:00:00 1970
Content-Type: multipart/mixed; boundary="===============7347810341954365048=="
MIME-Version: 1.0
From: Denis Kenzior <denkenz@gmail.com>
Subject: Re: [PATCH 6/6] gemalto: fix sim reinsertion issue
Date: Thu, 15 Mar 2018 12:29:42 -0500
Message-ID: <89854b1f-cb26-e9be-c0cc-aca226ddfb41@gmail.com>
In-Reply-To: <1521118170-23722-7-git-send-email-gabriel.lucas@smile.fr>
List-Id: <ofono.ofono.org>
To: ofono@ofono.org

--===============7347810341954365048==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

Hi Gabriel,

On 03/15/2018 07:49 AM, Gabriel Lucas wrote:
> When the SIM card is reinserted in the holder,
> the IRC +CIEV: simstatus,1 is emitted. The problem
> is that the SIM isn't ready when it is received.
> Hence, Ofono fails on CPIN? command and the modem
> cannot be used. This patch make ofono retry the
> CPIN? command until it succeeds.
> ---
>   plugins/gemalto.c | 29 ++++++++++++++++++++++++++++-
>   1 file changed, 28 insertions(+), 1 deletion(-)
> =

> diff --git a/plugins/gemalto.c b/plugins/gemalto.c
> index c7fb783..caa5912 100644
> --- a/plugins/gemalto.c
> +++ b/plugins/gemalto.c
> @@ -497,6 +497,33 @@ static void gemalto_set_online(struct ofono_modem *m=
odem, ofono_bool_t online,
>   	g_free(cbd);
>   }
>   =

> +static void sim_pin_query_cb(const struct ofono_error *error,
> +				enum ofono_sim_password_type pin_type,
> +				void *data);
> +
> +static void gemalto_wait_after_plug(struct ofono_sim *sim) {
> +	ofono_sim_get_driver(sim)->query_passwd_state(sim, sim_pin_query_cb, si=
m);
> +}
> +
> +static gboolean cpin_timeout(gpointer sim) {
> +	gemalto_wait_after_plug(sim);
> +
> +	return FALSE;
> +}
> +
> +static void sim_pin_query_cb(const struct ofono_error *error,
> +				enum ofono_sim_password_type pin_type,
> +				void *data) {
> +	struct ofono_sim *sim =3D data;
> +
> +	if (error->type !=3D OFONO_ERROR_TYPE_NO_ERROR) {
> +		g_timeout_add(50, cpin_timeout, sim);
> +	}
> +	else {
> +		ofono_sim_inserted_notify(sim, TRUE);
> +	}
> +}
> +
>   static void gemalto_ciev_notify(GAtResult *result, gpointer user_data)
>   {
>   	struct ofono_sim *sim =3D user_data;
> @@ -523,7 +550,7 @@ static void gemalto_ciev_notify(GAtResult *result, gp=
ointer user_data)
>   	if (status =3D=3D 0) {
>   		ofono_sim_inserted_notify(sim, FALSE);
>   	} else if(status =3D=3D 1) {
> -		ofono_sim_inserted_notify(sim, TRUE);
> +		gemalto_wait_after_plug(sim);

Why don't you just use at_util_sim_state_query_new here?

>   	}
>   }
>   =

> =


Regards,
-Denis

--===============7347810341954365048==--