From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/4] plugins: support for Telit LE910 V2 modem
Date: Wed, 25 Jan 2017 10:37:15 -0600 [thread overview]
Message-ID: <9d8917de-c2ec-70e5-32fb-64ccc5897de2@gmail.com> (raw)
In-Reply-To: <20170125104128.5254-3-gluedig@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 773 bytes --]
On 01/25/2017 04:41 AM, Piotr Haber wrote:
> LE910 V2 is next generation Telit LTE modem.
> It supports 3GPP Rel. 9 LTE Cat. 4 over multiple bands.
> Default USB composition uses PID 0x36 and
> consists of 6 CDC-ACM serial ports and 1 CDC-NCM network adapter.
> ---
> Makefile.am | 3 +
> plugins/le910v2.c | 400 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 403 insertions(+)
> create mode 100644 plugins/le910v2.c
>
Can you add the LE910 changes into the HE910 driver? The two are 99%
the same except for HE910 supporting voice calls and LE910 using a
different gprs_context driver.
There's no sense in maintaining a 400 line driver that is virtually
identical to what we already have.
Regards,
-Denis
next prev parent reply other threads:[~2017-01-25 16:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 14:21 [PATCH v2] drivers: add support for Telit LE910 V2 modem Piotr Haber
2017-01-24 18:55 ` Denis Kenzior
2017-01-25 10:41 ` [PATCH 0/4] add support for Telit LE910V2 Piotr Haber
2017-01-25 10:41 ` [PATCH 1/4] telitmodem: support for CDC-NCM network adapter Piotr Haber
2017-01-25 16:33 ` Denis Kenzior
2017-01-25 10:41 ` [PATCH 2/4] plugins: support for Telit LE910 V2 modem Piotr Haber
2017-01-25 16:37 ` Denis Kenzior [this message]
2017-01-26 9:09 ` gluedig
2017-01-26 9:40 ` Antoine Aubert
2017-01-26 11:13 ` gluedig
2017-01-26 13:46 ` Denis Kenzior
2017-01-25 10:41 ` [PATCH 3/4] doc: description of Telit LE910V2 network setup Piotr Haber
2017-01-25 16:38 ` Denis Kenzior
2017-01-25 10:41 ` [PATCH 4/4] udevng: setup of Telit LE910V2 Piotr Haber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d8917de-c2ec-70e5-32fb-64ccc5897de2@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox