Open Source Telephony
 help / color / mirror / Atom feed
From: Sicelo <absicsz@gmail.com>
To: ofono@lists.linux.dev
Subject: Re: isimodem/n900: CLIP and list-operators not working under Alpine Linux
Date: Sat, 28 Oct 2023 08:26:06 +0200	[thread overview]
Message-ID: <ZTypfrSeWHBxtRnM@tp440p.steeds.sam> (raw)
In-Reply-To: <ZS0fnIsQP9t8V-kY@tp440p.steeds.sam>

Hi

On Mon, Oct 16, 2023 at 01:33:48PM +0200, Sicelo wrote:
> Hi
> 
> Since a number of versions ago, the Nokia N900 modem does not return
> anything to the `list-operators` command under Alpine/PostmarketOS [1].
> With recent testing, it was found that even the CLIP is not displayed on
> an incoming call.
> 
> However, both `list-operators` and CLIP are working fine in Maemo Leste,
> a distribution derived from Debian.
> 
> The major difference between Maemo Leste and PostmarketOS is that the
> former is a glibc distro, while the latter uses musl. I am mentioning
> this in case it is useful, otherwise I have not yet found anything
> specific between the two libraries that could cause the observed
> differences.

The patch below fixes both issues (tested against ofono 1.34).
Should I submit it as a real patch, or there is a possibility that it
would negatively affect other systems?

The documentation for `g_convert` states "Using extensions such as
“//TRANSLIT” may not work (or may not work well) on many platforms.
Consider using g_str_to_ascii() instead."

Thanks for help.

Sincerely
Sicelo



diff --git a/gisi/iter.c b/gisi/iter.c
index 3cc1ae37..f36d38a9 100644
--- a/gisi/iter.c
+++ b/gisi/iter.c
@@ -257,7 +257,7 @@ gboolean g_isi_sb_iter_get_alpha_tag(const GIsiSubBlockIter *restrict iter,
        if (ucs2 + len > iter->end)
                return FALSE;

-       *utf8 = g_convert((const char *) ucs2, len, "UTF-8//TRANSLIT",
+       *utf8 = g_convert((const char *) ucs2, len, "UTF-8",
                                "UCS-2BE", NULL, NULL, NULL);
        return *utf8 != NULL;
 }




  reply	other threads:[~2023-10-28  6:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-16 11:33 isimodem/n900: CLIP and list-operators not working under Alpine Linux Sicelo
2023-10-28  6:26 ` Sicelo [this message]
2023-10-29 21:20   ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZTypfrSeWHBxtRnM@tp440p.steeds.sam \
    --to=absicsz@gmail.com \
    --cc=ofono@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox