From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: GPRS Attach/Detach
Date: Wed, 14 Feb 2018 10:54:43 -0600 [thread overview]
Message-ID: <a1122a66-e232-be39-529a-76540df4494c@gmail.com> (raw)
In-Reply-To: <CAKsXZz2n2Wgy94aNuJa0x643Gc-YQ6OVPJoamMzht0DBM-CmTA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 815 bytes --]
Hi Nikolas,
> I had to remove the `else if (have_active_contexts(gprs) == TRUE) { ...
> }` block because when attached was TRUE i still had active context and i
> didn't want it to be deactivated.
This particular logic was added in commit:
154f4aca65b3b419239be75d0def276bd7f4dc8e
>
> As the comments say it's to mitigate some PPP issues. Should that be the
> case for all type of connections? What if my connection is RNDIS and not
> PPP?
>
Doesn't seem to have anything to do with PPP actually. Anyway, there
should be no active contexts if we're detached. Otherwise this will
confuse ConnMan, NetworkManager, etc. The core tries to work around
some of the more common issues, but ultimately the driver needs to make
sure the transitions are well behaved.
Regards,
-Denis
next prev parent reply other threads:[~2018-02-14 16:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 10:03 GPRS Attach/Detach Nikolas Sepos
2018-02-14 16:54 ` Denis Kenzior [this message]
2018-02-19 12:55 ` Nikolas Sepos
2018-02-19 16:36 ` Denis Kenzior
2018-02-19 17:58 ` Nikolas Sepos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1122a66-e232-be39-529a-76540df4494c@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox