From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============0518856236959741224==" MIME-Version: 1.0 From: Denis Kenzior Subject: Re: [PATCH 6/8] gprs-context : Force use of atd99 Date: Sun, 17 Feb 2019 21:08:12 -0600 Message-ID: In-Reply-To: <20190215121142.28163-7-philippedeswert@gmail.com> List-Id: To: ofono@ofono.org --===============0518856236959741224== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Philippe, On 02/15/2019 06:11 AM, philippedeswert(a)gmail.com wrote: > From: Philippe De Swert > = > QUIRCK: For some reason I really need to force the use of the atd99 comma= nd here. > --- > drivers/atmodem/gprs-context.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > = > diff --git a/drivers/atmodem/gprs-context.c b/drivers/atmodem/gprs-contex= t.c > index 93894efd..a0776f2a 100644 > --- a/drivers/atmodem/gprs-context.c > +++ b/drivers/atmodem/gprs-context.c > @@ -214,7 +214,7 @@ static void at_cgdcont_cb(gboolean ok, GAtResult *res= ult, gpointer user_data) > return; > } > = > - if (gcd->use_atd99) > + if (gcd->use_atd99 || gcd->vendor =3D=3D OFONO_VENDOR_UBLOX) > sprintf(buf, "ATD*99***%u#", gcd->active_context); > else > sprintf(buf, "AT+CGDATA=3D\"PPP\",%u", gcd->active_context); > @@ -457,6 +457,9 @@ static int at_gprs_context_probe(struct ofono_gprs_co= ntext *gc, > case OFONO_VENDOR_SIMCOM_SIM900: > gcd->use_atd99 =3D FALSE; > break; > + case OFONO_VENDOR_UBLOX: > + gcd->use_atd99 =3D TRUE; > + break; So why use both use_atd99 and a vendor quirk above? Also, you're = affecting other uBlox users, so do you want to introduce a different = VENDOR quirk instead? > default: > g_at_chat_send(chat, "AT+CGDATA=3D?", cgdata_prefix, > at_cgdata_test_cb, gc, NULL); > = Regards, -Denis --===============0518856236959741224==--