From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] atmodem: Fix use after free in sim_state_cb
Date: Thu, 05 Oct 2017 11:11:37 -0500 [thread overview]
Message-ID: <bcffc506-5555-e073-4750-0ddf28706729@gmail.com> (raw)
In-Reply-To: <1507217783-13414-1-git-send-email-slava.monich@jolla.com>
[-- Attachment #1: Type: text/plain, Size: 1730 bytes --]
Hi Slava,
On 10/05/2017 10:36 AM, Slava Monich wrote:
> ==2941== Invalid read of size 4
> ==2941== at 0x69338: sim_state_cb (sim.c:1301)
> ==2941== by 0x71DCB: cpin_check_cb (atutil.c:567)
> ==2941== by 0xA602B: at_chat_finish_command (gatchat.c:459)
> ==2941== by 0xA6277: at_chat_handle_command_response (gatchat.c:521)
> ==2941== by 0xA6587: have_line (gatchat.c:600)
> ==2941== by 0xA6BB7: new_bytes (gatchat.c:759)
> ==2941== by 0xAAFAF: received_data (gatio.c:124)
> ==2941== by 0x4AF606F: g_main_dispatch (gmain.c:3154)
> ==2941== by 0x4AF606F: g_main_context_dispatch (gmain.c:3769)
> ==2941== by 0x4AF658F: g_main_loop_run (gmain.c:4034)
> ==2941== by 0xBDDBB: main (main.c:261)
> ==2941== Address 0x519c344 is 4 bytes inside a block of size 12 free'd
> ==2941== at 0x4840B28: free (vg_replace_malloc.c:530)
> ==2941== by 0x71F33: at_util_sim_state_query_free (atutil.c:613)
> ==2941== by 0x6930B: sim_state_cb (sim.c:1297)
> ==2941== by 0x71DCB: cpin_check_cb (atutil.c:567)
> ==2941== by 0xA602B: at_chat_finish_command (gatchat.c:459)
> ==2941== by 0xA6277: at_chat_handle_command_response (gatchat.c:521)
> ==2941== by 0xA6587: have_line (gatchat.c:600)
> ==2941== by 0xA6BB7: new_bytes (gatchat.c:759)
> ==2941== by 0xAAFAF: received_data (gatio.c:124)
> ==2941== by 0x4AF606F: g_main_dispatch (gmain.c:3154)
> ==2941== by 0x4AF606F: g_main_context_dispatch (gmain.c:3769)
> ==2941== by 0x4AF658F: g_main_loop_run (gmain.c:4034)
> ==2941== by 0xBDDBB: main (main.c:261)
> ---
> drivers/atmodem/sim.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
Applied, thanks.
Regards,
-Denis
prev parent reply other threads:[~2017-10-05 16:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 15:36 [PATCH] atmodem: Fix use after free in sim_state_cb Slava Monich
2017-10-05 16:11 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcffc506-5555-e073-4750-0ddf28706729@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox