Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] gprs: deattach driver when gprs status indicates unregistered
Date: Fri, 20 Sep 2019 09:58:51 -0500	[thread overview]
Message-ID: <be8a9d4e-a0dd-22fe-5630-e43453ebf0bc@gmail.com> (raw)
In-Reply-To: <20190917214807.19663-1-richard.rojfors@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 726 bytes --]

Hi Richard,

On 9/17/19 4:48 PM, richard.rojfors(a)gmail.com wrote:
> From: Richard Röjfors <richard@puffinpack.se>
> 
> In the same way as we consider the driver attached when the
> gprs status indicates we are registered, we should consider
> it deattached when the status indicates unregistration.
> 
> If we don't, then we would not always recover from the case
> when deattaching the driver fails. We would just revert back
> the driver attached status to true, and "ignore" if the status
> indicates the opposite when we check the registration status
> afterwards.
> ---
>   src/gprs.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 

Applied, thanks.

Regards,
-Denis


      parent reply	other threads:[~2019-09-20 14:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-17 21:48 [PATCH] gprs: deattach driver when gprs status indicates unregistered richard.rojfors
2019-09-17 21:56 ` Richard =?unknown-8bit?q?R=C3=B6jfors?=
2019-09-20 14:58 ` Denis Kenzior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be8a9d4e-a0dd-22fe-5630-e43453ebf0bc@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox