Re: [PATCH 1/3] gobi: do not assume LTE is supported, detect it

[Denis Kenzior <denkenz@gmail.com>]

Hi Ivo,

On 7/29/25 12:21 AM, Ivaylo Dimitrov wrote:
> ---
>   plugins/gobi.c | 17 +++++++++++++----
>   1 file changed, 13 insertions(+), 4 deletions(-)

<snip>

> @@ -480,8 +480,17 @@ static void get_caps_cb(struct qmi_result *result, void *user_data)
>           DBG("service capabilities %d", caps->data_capa);
>           DBG("sim supported %d", caps->sim_supported);
>   
> -        for (i = 0; i < caps->radio_if_count; i++)
> -                DBG("radio = %d", caps->radio_if[i]);
> +	for (i = 0; i < caps->radio_if_count; i++) {
> +		uint8_t iface = caps->radio_if[i];
> +
> +		DBG("radio = %d", iface);
> +
> +		if (iface & QMI_DMS_RADIO_IF_LTE)

QMI_DMS_RADIO_IF_* do not seem to be values that can be used in a bitset, so I 
amended this line to use '==' instead of '&'.

> +			data->features |= GOBI_LTE;
> +	}
> +
> +	if (data->features & GOBI_LTE)
> +		ofono_modem_set_capabilities(modem, OFONO_MODEM_CAPABILITY_LTE);
>   
>   	if (qmi_service_send(data->dms, QMI_DMS_GET_OPER_MODE, NULL,
>   					get_oper_mode_cb, modem, NULL) > 0)

Regards,
-Denis