From: Inaky Perez-Gonzalez <inaky@linux.intel.com>
To: ofono@ofono.org
Subject: [SMS D-Bus 00/19] pull request
Date: Tue, 03 Aug 2010 16:50:49 -0700 [thread overview]
Message-ID: <cover.1280879410.git.inaky.perez-gonzalez@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 3213 bytes --]
From: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
- UUID code reworked, simplified to Dennis' suggestion
- UUID code integrated -- still kind of incomplete because we need to
see what to do when the message contents and destination number is
the same.
- BUG_ON* removed, not used anymore
- removed 'struct sms_msg_dbus_data', pass around 'dbus_path' as
private data.
- D-Bus:
number of PDUs not longer part of the D-Bus name
added 'To' to the D-Bus properties; ignored for now
submittion/delivery times as it will complicate the interface -- we
need another callback for property change specification. Is it worth
it?
Fixed GetProperties method mistakenly marked ASYNC
Interface renamed to SmsManager
Cleaned up doc/sms-api.txt according to feedback
- unfolded tx_queue_entry_destroy_free into
tx_queue_entry_free_foreach() and tx_queue_entry_free() according to
feedback.
- broke up multi-directory commits
- cleaned up style violations
- add a fix to generation of symlinks for headers, it broke in VPATH
builds.
The following changes since commit 6f1ab8b6794333673fefc3d52f9b0388526a56cd:
Kristen Carlson Accardi (1):
test-stkutil: unit test for img to xpm converter
are available in the git repository at:
git://gitorious.org/~inakypg/ofono/ofono-inakypg.git master
Patches follow for reviewing convenience.
Inaky Perez-Gonzalez (19):
write_file: make transaction-safe
sms: introduce message ID API
sms: implement SHA256-based message IDs [incomplete]
sms: document the org.ofono.SmsMessage interface
sms: document handle_sms_status_report()
struct tx_queue_entry: add a destructor
sms: introduce bare state machine and transitions
sms: introduce the Wait-for-Status-Report state
sms: introduce a state change callback for messages
sms: export outgoing messages over D-Bus
sms: send PropertyChanged signals on state change
sms: introduce sms_msg_cancel and its D-Bus wrapper
sms: Implement D-Bus SMS-MSG::GetProperties
sms: document SMS Message's D-Bus 'To' property
sms: test code for message's D-Bus GetProperties
automake: fix generation of symlinks for headers
sms: document variable usage in sms_msg_send()
sms: add test case for message cancel
sms: add test case for state change signals
Makefile.am | 2 +-
doc/sms-api.txt | 54 ++++-
src/ofono.h | 45 +++-
src/sms.c | 581 ++++++++++++++++++++++++++++++++------
src/smsutil.c | 78 +++++
src/smsutil.h | 8 +
src/stk.c | 22 ++-
src/storage.c | 47 +++-
test/test-sms-msg-cancel | 173 +++++++++++
test/test-sms-msg-get-properties | 26 ++
test/test-sms-msg-state-change | 24 ++
11 files changed, 951 insertions(+), 109 deletions(-)
create mode 100755 test/test-sms-msg-cancel
create mode 100755 test/test-sms-msg-get-properties
create mode 100755 test/test-sms-msg-state-change
next reply other threads:[~2010-08-03 23:50 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-03 23:50 Inaky Perez-Gonzalez [this message]
2010-08-03 23:50 ` [SMS D-Bus 01/19] write_file: make transaction-safe Inaky Perez-Gonzalez
2010-08-05 17:03 ` Denis Kenzior
2010-08-03 23:50 ` [SMS D-Bus 02/19] sms: introduce message ID API Inaky Perez-Gonzalez
2010-08-05 17:10 ` Denis Kenzior
2010-08-05 17:18 ` Inaky Perez-Gonzalez
2010-08-05 18:02 ` Denis Kenzior
2010-08-05 18:07 ` Inaky Perez-Gonzalez
2010-08-05 18:21 ` Denis Kenzior
2010-08-05 18:37 ` Inaky Perez-Gonzalez
2010-08-05 23:34 ` Inaky Perez-Gonzalez
2010-08-03 23:50 ` [SMS D-Bus 03/19] sms: implement SHA256-based message IDs [incomplete] Inaky Perez-Gonzalez
2010-08-05 17:20 ` Denis Kenzior
2010-08-05 18:17 ` Inaky Perez-Gonzalez
2010-08-03 23:50 ` [SMS D-Bus 04/19] sms: document the org.ofono.SmsMessage interface Inaky Perez-Gonzalez
2010-08-03 23:50 ` [SMS D-Bus 05/19] sms: document handle_sms_status_report() Inaky Perez-Gonzalez
2010-08-03 23:50 ` [SMS D-Bus 06/19] struct tx_queue_entry: add a destructor Inaky Perez-Gonzalez
2010-08-05 17:04 ` Denis Kenzior
2010-08-03 23:50 ` [SMS D-Bus 07/19] sms: introduce bare state machine and transitions Inaky Perez-Gonzalez
2010-08-03 23:50 ` [SMS D-Bus 08/19] sms: introduce the Wait-for-Status-Report state Inaky Perez-Gonzalez
2010-08-03 23:50 ` [SMS D-Bus 09/19] sms: introduce a state change callback for messages Inaky Perez-Gonzalez
2010-08-03 23:50 ` [SMS D-Bus 10/19] sms: export outgoing messages over D-Bus Inaky Perez-Gonzalez
2010-08-03 23:51 ` [SMS D-Bus 11/19] sms: send PropertyChanged signals on state change Inaky Perez-Gonzalez
2010-08-03 23:51 ` [SMS D-Bus 12/19] sms: introduce sms_msg_cancel and its D-Bus wrapper Inaky Perez-Gonzalez
2010-08-03 23:51 ` [SMS D-Bus 13/19] sms: Implement D-Bus SMS-MSG::GetProperties Inaky Perez-Gonzalez
2010-08-03 23:51 ` [SMS D-Bus 14/19] sms: document SMS Message's D-Bus 'To' property Inaky Perez-Gonzalez
2010-08-03 23:51 ` [SMS D-Bus 15/19] sms: test code for message's D-Bus GetProperties Inaky Perez-Gonzalez
2010-08-03 23:51 ` [SMS D-Bus 16/19] automake: fix generation of symlinks for headers Inaky Perez-Gonzalez
2010-08-03 23:51 ` [SMS D-Bus 17/19] sms: document variable usage in sms_msg_send() Inaky Perez-Gonzalez
2010-08-03 23:51 ` [SMS D-Bus 18/19] sms: add test case for message cancel Inaky Perez-Gonzalez
2010-08-03 23:51 ` [SMS D-Bus 19/19] sms: add test case for state change signals Inaky Perez-Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1280879410.git.inaky.perez-gonzalez@intel.com \
--to=inaky@linux.intel.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox