From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH v3] quectel: EC21 needs aux channel to be the first mux channel
Date: Tue, 28 Jul 2020 11:40:35 -0500 [thread overview]
Message-ID: <e63d269e-e40b-63f7-2e95-135f06cb038e@gmail.com> (raw)
In-Reply-To: <20200724110209.qwijmpzjv6nioeqt@lem-wkst-02.lemonage>
[-- Attachment #1: Type: text/plain, Size: 2021 bytes --]
Hi Lars,
>
> Unfortunately I must come back to this issue.
> I got hands on a few new EC21s here and guess what ?
> The mux order is back to the original one again. This means, the aux
> channel has to be the second channel.
> So I did a bit of investigation why and when this happened. But
> information is rare.
> The modems I originally worked on and created the patch for have
> Firmware EC21EFAR06A01M4G_BETA0318. (Reversed mux order)
> The new ones do have version EC21EFAR06A03M4G. (original mux order)
> I know that there was a version EC21EFAR02A02M4G that did not support
> cmux at all.
> Due to some Quectel Confidential Document in a firmware version
> "R02A03" some bug was fixed in cmux, so cmux must be in there since
> then.
> The EC21EFAR06A01M4G_BETA0318 that I have is dated inbetween
> EC21EFAR02A02M4G and this "R02A03".
> The mux order must have changed between EC21EFAR06A01M4G_BETA0318 and
> EC21EFAR06A03M4G.
> I suspect (without knowing for sure) due to the beta-nature of my
> firmware, that this is the only firmware with reversed mux order and
> that they changed it after that and "R02A03" up until
> EC21EFAR06A03M4G share the same original mux order. According to Quectel
> the EC21EFAR06A01M4G_BETA0318 firmware I have here is not "out in the
> wild". The modems I have here are the only ones with this firmware.
>
> So my question is what's best to do now ?
>
> I feel the best would be to revert this patch. I am very sorry for this.
> New modems will work and I suspect old modems "out in the wild" will
> work also. I don't care about supporting the few "BETA0318" modems I
> have here.
I guess just send a revert patch with the reasons outlined in the commit
description and I can take it.
>
> Another way would be to leave this patch and implement some firmware
> switch and use reversed mux order for the "BETA0318" only I have and use
> normal original mux order for all other cases.
That would also be fine.
Regards,
-Denis
next prev parent reply other threads:[~2020-07-28 16:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 10:16 [PATCH 0/7] Add quectel EC21 in serial mode poeschel
2020-05-26 10:16 ` [PATCH 1/7] quectel: Add Quectel EC21 to known serial modems poeschel
2020-05-26 10:16 ` [PATCH 2/7] quectel: use lte atom on EC21 poeschel
2020-05-26 10:16 ` [PATCH 3/7] quectel: Query the model before setting up the mux poeschel
2020-05-26 10:16 ` [PATCH 4/7] quectel: EC21 needs aux channel to be the first mux channel poeschel
2020-05-26 16:14 ` Denis Kenzior
2020-05-27 15:08 ` Lars Poeschel
2020-05-28 9:32 ` [PATCH v2] " poeschel
2020-05-28 16:25 ` Denis Kenzior
2020-05-29 12:43 ` [PATCH v3] " poeschel
2020-05-29 14:58 ` Denis Kenzior
2020-07-24 11:02 ` Lars Poeschel
2020-07-28 16:40 ` Denis Kenzior [this message]
2020-08-04 11:56 ` [PATCH] Revert "quectel: EC21 needs aux channel to be the first mux channel" poeschel
2020-08-07 16:07 ` Denis Kenzior
2020-05-26 10:16 ` [PATCH 5/7] quectel: EC21 does not understand AT+QIURC poeschel
2020-05-26 10:16 ` [PATCH 6/7] voicecall: Quectel modem do not understand AT+CNAP poeschel
2020-05-26 10:16 ` [PATCH 7/7] quectel: EC21 add ussd with atmodem driver poeschel
2020-05-26 16:09 ` [PATCH 0/7] Add quectel EC21 in serial mode Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e63d269e-e40b-63f7-2e95-135f06cb038e@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox