From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 4/4] MC7430: fix QMI notification messages handling
Date: Fri, 30 Dec 2016 18:39:46 -0600 [thread overview]
Message-ID: <e8046724-99a8-d683-da02-856a04a970ea@gmail.com> (raw)
In-Reply-To: <20161228150402.15660-5-c.ronco@kerlink.fr>
[-- Attachment #1: Type: text/plain, Size: 593 bytes --]
Hi Christophe,
On 12/28/2016 09:04 AM, Christophe Ronco wrote:
> QMI notification messages handlers are never called on MC7430 without this fix.
>
> drivers/qmimodem/qmi.c
> Do not test transaction id before calling notification handler.
> On MC7430, notification messages contain a not null transaction id
> (starts with 1, increased at each message for a particular client).
> On MC7304 transaction id in notification messages is always 0.
> ---
> drivers/qmimodem/qmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks!
Regards,
-Denis
prev parent reply other threads:[~2016-12-31 0:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-28 15:03 [PATCH 0/4] support MC7430 Sierra modem Christophe Ronco
2016-12-28 15:03 ` [PATCH 1/4] MC7430: use qmimodem sim driver Christophe Ronco
2017-01-03 16:43 ` Denis Kenzior
2016-12-28 15:04 ` [PATCH 2/4] MC7430: add read_imsi feature to " Christophe Ronco
2016-12-31 0:34 ` Denis Kenzior
2017-01-06 8:16 ` Christophe Ronco
2017-01-06 16:50 ` Denis Kenzior
2017-01-09 8:34 ` [PATCH 0/2] Fix Read Imsi feature for MC7430 modem Christophe Ronco
2017-01-09 8:34 ` [PATCH 1/2] sim: backup driver read_imsi by IMSI via EF read Christophe Ronco
2017-01-09 8:34 ` [PATCH 2/2] qmimodem: Add read_imsi to qmimodem sim driver Christophe Ronco
2017-01-09 18:32 ` [PATCH 0/2] Fix Read Imsi feature for MC7430 modem Denis Kenzior
2016-12-28 15:04 ` [PATCH 3/4] MC7430: fix get signal strength Christophe Ronco
2016-12-31 0:36 ` Denis Kenzior
2016-12-28 15:04 ` [PATCH 4/4] MC7430: fix QMI notification messages handling Christophe Ronco
2016-12-31 0:39 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8046724-99a8-d683-da02-856a04a970ea@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox