From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 4/6] gemalto: handle sim is inserted or removed URCs
Date: Mon, 19 Mar 2018 12:10:57 -0500 [thread overview]
Message-ID: <eb26b058-ae40-367a-6fdc-b7e341e75370@gmail.com> (raw)
In-Reply-To: <1521476808-12688-1-git-send-email-gabriel.lucas@smile.fr>
[-- Attachment #1: Type: text/plain, Size: 792 bytes --]
Hi Gabriel, Mariem,
On 03/19/2018 11:26 AM, Gabriel Lucas wrote:
> From: Mariem Cherif <mariem.cherif@ardia.com.tn>
>
> ---
> plugins/gemalto.c | 78 ++++++++++++++++++++++++++++++++++++++++++++++++++++---
> 1 file changed, 74 insertions(+), 4 deletions(-)
>
> diff --git a/plugins/gemalto.c b/plugins/gemalto.c
> index 5573606..029e09d 100644
> --- a/plugins/gemalto.c
> +++ b/plugins/gemalto.c
> @@ -57,6 +57,8 @@
> #define GEMALTO_MODEL_PHS8P "0053"
> #define GEMALTO_MODEL_ALS3 "0061"
>
> +static void gemalto_ciev_notify(GAtResult *result, gpointer user_data);
> +
Please note doc/coding-style.txt item M17. I silently re-structured
this patch to avoid the need for this forward-declaration.
Patch has been applied, thanks!
Regards,
-Denis
next prev parent reply other threads:[~2018-03-19 17:10 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 12:49 [PATCH 0/6] gemalto's ALS3 and PHS8P support Gabriel Lucas
2018-03-15 12:49 ` [PATCH 1/6] gemalto: add detection of ALS3 modem Gabriel Lucas
2018-03-15 17:22 ` Denis Kenzior
2018-03-15 12:49 ` [PATCH 2/6] gemalto: support ALS3 in gemalto's plugin Gabriel Lucas
2018-03-15 17:11 ` Denis Kenzior
2018-03-16 10:30 ` Gabriel Lucas
2018-03-16 14:23 ` Denis Kenzior
2018-03-16 15:53 ` Gabriel Lucas
2018-03-16 15:59 ` Gabriel Lucas
2018-03-16 16:08 ` Gabriel Lucas
2018-03-16 16:08 ` Denis Kenzior
2018-03-19 9:45 ` Gabriel Lucas
2018-03-19 13:50 ` Denis Kenzior
2018-03-19 15:15 ` Gabriel Lucas
2018-03-19 15:24 ` Denis Kenzior
2018-03-15 12:49 ` [PATCH 3/6] gemalto: acquire the network technology Gabriel Lucas
2018-03-15 17:19 ` Denis Kenzior
2018-03-16 12:04 ` Gabriel Lucas
2018-03-16 12:59 ` Gabriel Lucas
2018-03-16 14:27 ` Denis Kenzior
2018-03-16 15:30 ` Gabriel LUCAS
2018-03-15 12:49 ` [PATCH 4/6] gemalto: handle sim is inserted or removed URCs Gabriel Lucas
2018-03-15 17:26 ` Denis Kenzior
2018-03-16 13:28 ` Gabriel Lucas
2018-03-16 14:03 ` Denis Kenzior
2018-03-19 15:57 ` Gabriel Lucas
2018-03-19 16:08 ` Denis Kenzior
2018-03-19 16:26 ` Gabriel Lucas
2018-03-19 17:10 ` Denis Kenzior [this message]
2018-03-20 8:37 ` Gabriel Lucas
2018-03-15 12:49 ` [PATCH 5/6] sim: give access to the driver Gabriel Lucas
2018-03-15 17:27 ` Denis Kenzior
2018-03-15 12:49 ` [PATCH 6/6] gemalto: fix sim reinsertion issue Gabriel Lucas
2018-03-15 17:29 ` Denis Kenzior
2018-03-16 13:30 ` Gabriel Lucas
2018-03-19 16:01 ` Gabriel Lucas
-- strict thread matches above, loose matches on Subject: below --
2018-03-12 13:19 [PATCH 3/6] gemalto: acquire the network technology Gabriel Lucas
2018-03-12 13:19 ` [PATCH 4/6] gemalto: handle sim is inserted or removed URCs Gabriel Lucas
2018-03-12 13:12 [PATCH 3/6] gemalto: acquire the network technology Gabriel Lucas
2018-03-12 13:12 ` [PATCH 4/6] gemalto: handle sim is inserted or removed URCs Gabriel Lucas
2018-03-12 12:57 [PATCH 0/6] gemalto's ALS3 and PHS8P support Gabriel Lucas
2018-03-12 12:57 ` [PATCH 4/6] gemalto: handle sim is inserted or removed URCs Gabriel Lucas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb26b058-ae40-367a-6fdc-b7e341e75370@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox