Open Source Telephony
 help / color / mirror / Atom feed
From: Andrzej Zaborowski <andrew.zaborowski@intel.com>
To: ofono@ofono.org
Subject: Re: [PATCH] Implement writing EF-MBDN on SetProperty or Enhanced Voicemail IE.
Date: Wed, 05 Aug 2009 18:33:49 +0200	[thread overview]
Message-ID: <fb249edb0908050933v78a979abrcde608cf71f00ef7@mail.gmail.com> (raw)
In-Reply-To: <1249456120-10263-1-git-send-email-andrew.zaborowski@intel.com>

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

2009/8/5 Andrzej Zaborowski <andrew.zaborowski@intel.com>:
> I've not tested this on a real SIM yet.

It needs the attached fix since the record numbers passed to the
plugin are now 1-based.

Regards

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-record-number-in-at_sim_update_record.patch --]
[-- Type: text/x-patch, Size: 758 bytes --]

From 2b689be0c8cebc773679a60a4103cff29b6b29d5 Mon Sep 17 00:00:00 2001
From: Andrzej Zaborowski <andrew.zaborowski@intel.com>
Date: Wed, 5 Aug 2009 11:25:21 +0200
Subject: [PATCH] Fix record number in at_sim_update_record.

---
 drivers/atmodem/sim.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c
index 748cf6a..90f02e2 100644
--- a/drivers/atmodem/sim.c
+++ b/drivers/atmodem/sim.c
@@ -321,7 +321,7 @@ static void at_sim_update_record(struct ofono_modem *modem, int fileid,
 		goto error;
 
 	len = sprintf(buf, "AT+CRSM=220,%i,%i,4,%i,", fileid,
-			record + 1, length);
+			record, length);
 
 	for (; length; length--)
 		len += sprintf(buf + len, "%02hhx", *value++);
-- 
1.6.1


  reply	other threads:[~2009-08-05 16:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-05  7:08 [PATCH] Implement writing EF-MBDN on SetProperty or Enhanced Voicemail IE Andrzej Zaborowski
2009-08-05 16:33 ` Andrzej Zaborowski [this message]
2009-08-05 17:48   ` Denis Kenzior
2009-08-05 18:59 ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb249edb0908050933v78a979abrcde608cf71f00ef7@mail.gmail.com \
    --to=andrew.zaborowski@intel.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox