From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
To: op-tee@lists.trustedfirmware.org
Subject: Re: [Intel-wired-lan] [PATCH 000/141] Fix fall-through warnings for Clang
Date: Mon, 23 Nov 2020 07:03:48 -0600 [thread overview]
Message-ID: <20201123130348.GA3119@embeddedor> (raw)
In-Reply-To: < <dbd2cb703ed9eefa7dde9281ea26ab0f7acc8afe.camel@HansenPartnership.com>>
[-- Attachment #1: Type: text/plain, Size: 1626 bytes --]
On Sun, Nov 22, 2020 at 11:53:55AM -0800, James Bottomley wrote:
> On Sun, 2020-11-22 at 11:22 -0800, Joe Perches wrote:
> > On Sun, 2020-11-22 at 11:12 -0800, James Bottomley wrote:
> > > On Sun, 2020-11-22 at 10:25 -0800, Joe Perches wrote:
> > > > On Sun, 2020-11-22 at 10:21 -0800, James Bottomley wrote:
> > > > > Please tell me our reward for all this effort isn't a single
> > > > > missing error print.
> > > >
> > > > There were quite literally dozens of logical defects found
> > > > by the fallthrough additions. Very few were logging only.
> > >
> > > So can you give us the best examples (or indeed all of them if
> > > someone is keeping score)? hopefully this isn't a US election
> > > situation ...
> >
> > Gustavo? Are you running for congress now?
> >
> > https://lwn.net/Articles/794944/
>
> That's 21 reported fixes of which about 50% seem to produce no change
> in code behaviour at all, a quarter seem to have no user visible effect
> with the remaining quarter producing unexpected errors on obscure
> configuration parameters, which is why no-one really noticed them
> before.
The really important point here is the number of bugs this has prevented
and will prevent in the future. See an example of this, below:
https://lore.kernel.org/linux-iio/20190813135802.GB27392(a)kroah.com/
This work is still relevant, even if the total number of issues/bugs
we find in the process is zero (which is not the case).
"The sucky thing about doing hard work to deploy hardening is that the
result is totally invisible by definition (things not happening) [..]"
- Dmitry Vyukov
Thanks
--
Gustavo
next parent reply other threads:[~2020-11-23 13:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] < <dbd2cb703ed9eefa7dde9281ea26ab0f7acc8afe.camel@HansenPartnership.com>
2020-11-23 13:03 ` Gustavo A. R. Silva [this message]
2020-11-23 16:31 ` [Intel-wired-lan] [PATCH 000/141] Fix fall-through warnings for Clang James Bottomley
[not found] < <8f5611bb015e044fa1c0a48147293923c2d904e4.camel@HansenPartnership.com>
2020-11-24 21:32 ` Kees Cook
2020-11-24 22:24 ` Finn Thain
2020-11-24 23:15 ` Miguel Ojeda
2020-11-25 7:05 ` James Bottomley
[not found] < <CANiq72nUt57u5DG9rH=DB0DzQH7U6-QbG-2Ou+PyCY=p=_Ggag@mail.gmail.com>
2020-11-24 23:53 ` Finn Thain
2020-11-25 1:05 ` Miguel Ojeda
[not found] < <CAKwvOdkGBn7nuWTAqrORMeN1G+w3YwBfCqqaRD2nwvoAXKi=Aw@mail.gmail.com>
2020-11-25 16:24 ` Jakub Kicinski
2020-11-25 21:33 ` Finn Thain
2020-11-25 22:09 ` Nick Desaulniers
[not found] < <a841536fe65bb33f1c72ce2455a6eb47a0107565.camel@HansenPartnership.com>
2020-11-25 12:24 ` Nick Desaulniers
2020-11-25 21:10 ` Kees Cook
[not found] < <20201125082405.1d8c23dc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
2020-11-25 17:04 ` Miguel Ojeda
2020-11-25 22:09 ` Nick Desaulniers
[not found] < <CAKwvOdna5Zj_O=sB7Q0jHZX0BJSaakX=ZyftwQ_3=L3-ZB54XQ@mail.gmail.com>
2020-11-25 23:21 ` Finn Thain
2020-11-26 0:30 ` Finn Thain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201123130348.GA3119@embeddedor \
--to=gustavoars@kernel.org \
--cc=op-tee@lists.trustedfirmware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox